Date: Wed, 15 Jan 2003 14:42:29 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: Bruce Evans <bde@zeta.org.au> Cc: arch@FreeBSD.ORG Subject: Re: Buglet in disklabel Message-ID: <xzpheca4ji2.fsf@flood.ping.uio.no> In-Reply-To: <20030116003206.C23422-100000@gamplex.bde.org> (Bruce Evans's message of "Thu, 16 Jan 2003 00:35:00 %2B1100 (EST)") References: <20030116003206.C23422-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans <bde@zeta.org.au> writes:
> Looks good. You could also remove the bzero() before one of the calls
> to getasciilabel() (the one that passes a local variable that would
> more obviously be unitialized if it weren't bzero()ed).
Like this?
@@ -858,7 +858,6 @@
warnx("can't reopen %s for reading", tmpfil);
break;
}
- bzero((char *)&label, sizeof(label));
if (getasciilabel(fp, &label)) {
*lp = label;
if (writelabel(f, bootarea, lp) == 0) {
DES
--
Dag-Erling Smorgrav - des@ofug.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpheca4ji2.fsf>