Date: Thu, 8 Jan 2015 00:21:57 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Craig Rodrigues <rodrigc@FreeBSD.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis <nvass@gmx.com>, src-committers@freebsd.org Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <AEFC5AEF-7700-426A-96D3-A14BF68CA9BC@lists.zabbadoz.net> In-Reply-To: <20150107204631.GG15484@FreeBSD.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150107204631.GG15484@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 07 Jan 2015, at 20:46 , Gleb Smirnoff <glebius@freebsd.org> wrote: >=20 > On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: > C> Author: rodrigc > C> Date: Tue Jan 6 09:03:03 2015 > C> New Revision: 276747 > C> URL: https://svnweb.freebsd.org/changeset/base/276747 > C>=20 > C> Log: > C> Instead of creating a purge thread for every vnet, create > C> a single purge thread and clean up all vnets from this thread. > C> =20 > C> PR: 194515 > C> Differential Revision: D1315 > C> Submitted by: Nikos Vassiliadis <nvass@gmx.com> >=20 > I am not sure that this is a good idea. The core idea of VNETs > is that they are isolated from each other. If we serialize purging, > then vnets are strongly affecting each other. >=20 > AFAIU, from the PR there is some panic fixed. What is the actual bug > and why couldn't it be fixed with having per-vnet thread? You don=E2=80=99t 30000 whatever pf purging threads on a system all = running, possibly competing for some resources, e.g., locks? =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AEFC5AEF-7700-426A-96D3-A14BF68CA9BC>