Date: Thu, 25 Sep 2003 12:24:28 -0400 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: Josef El-Rayes <j.el-rayes@daemon.li> Cc: Ken Smith <kensmith@FreeBSD.org> Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml Message-ID: <20030925162427.GA12579@electra.cse.Buffalo.EDU> In-Reply-To: <20030925152525.GA410@daemon.li> References: <200309251252.h8PCq7Tc093693@repoman.freebsd.org> <20030925152525.GA410@daemon.li>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 25, 2003 at 05:25:25PM +0200, Josef El-Rayes wrote:
> Ken Smith <kensmith@FreeBSD.org> wrote:
> > - "whitespace change" that coverts existing driver example code
> > to be style(9) compliant, matching format of new driver code
>
> for me this is strange, i always thought that we do not do patches which
> do whitespace changes only - which does make the repository bigger
> without any real benefit.
> is there a special reason why we do this here?
In this case there is a special reason - the whitespace adjustments
are visible to the users. I was adjusting whitespace inside of
a program example. Someone else mentioned this as well, I was
making it style(9) compliant. IMO if the people who watch over
the source code commits are going to "insist" on style(9) compliance
we should make an effort for the examples in the online documentation
to also be style(9) compliant.
Should I phrase the commit log message in a different way if this
sort of thing happens again? Strictly speaking because the whitespace
changes are visible in the end result you could consider this a real
functional change. People tend to associate "whitespace change"
with "will be eaten by the SGML processors and makes no visible
change in the end result" but in cases like this that is not the case.
--
Ken Smith
- From there to here, from here to | kensmith@cse.buffalo.edu
there, funny things are everywhere. |
- Theodore Geisel |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030925162427.GA12579>