Date: Sun, 18 Mar 2012 15:46:59 -0700 From: Oleksandr Tymoshenko <gonzo@bluezbox.com> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-mips@freebsd.org Subject: Re: hwpmc(4) MIPS code refactoring / bugfixes Message-ID: <4F6665E3.1010802@bluezbox.com> In-Reply-To: <CAJ-Vmo=mAjPCoDb%2BpWTZEo3JXuqGh%2BjbAE=W-bZ7=vOt4xLjWA@mail.gmail.com> References: <A9B53A21-71EF-43A1-9354-A1F17013C496@bluezbox.com> <CAJ-Vmo=mAjPCoDb%2BpWTZEo3JXuqGh%2BjbAE=W-bZ7=vOt4xLjWA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18/03/2012 12:42 AM, Adrian Chadd wrote: > Hi! > > On 18 March 2012 00:24, Oleksandr Tymoshenko<gonzo@bluezbox.com> wrote: >> Hello, >> >> Proposed patch fixes some issues in hwpmc(4) and makes adding support >> for more MIPS CPUs much easier. I'd appreciate reviews and any >> feedback. >> >> http://people.freebsd.org/~gonzo/mips/pmc-2.diff > > Thanks for this! > > Some of this stuff looks like it can be committed as small, standalone fixes: > > * pmc_syscall_args is standalone, right? > * changing the MIPS rtld is also a separate commit > * same deal with pmcstat_log.c? But this would also impact non-MIPS > platforms so we'd have to test those? These are indeed self-contained fixes and I was going to make them separate commits. I tested syscall args fix and pmcstat_log.c changes on amd64 box - works fine.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F6665E3.1010802>