Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 May 2013 17:57:52 +0000 (UTC)
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r250518 - head/sys/netpfil/pf
Message-ID:  <201305111757.r4BHvqKu095997@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: glebius
Date: Sat May 11 17:57:52 2013
New Revision: 250518
URL: http://svnweb.freebsd.org/changeset/base/250518

Log:
  Invalid creatorid is always EINVAL, not only when we are in verbose mode.

Modified:
  head/sys/netpfil/pf/if_pfsync.c

Modified: head/sys/netpfil/pf/if_pfsync.c
==============================================================================
--- head/sys/netpfil/pf/if_pfsync.c	Sat May 11 16:47:42 2013	(r250517)
+++ head/sys/netpfil/pf/if_pfsync.c	Sat May 11 17:57:52 2013	(r250518)
@@ -408,9 +408,10 @@ pfsync_state_import(struct pfsync_state 
 
 	PF_RULES_RASSERT();
 
-	if (sp->creatorid == 0 && V_pf_status.debug >= PF_DEBUG_MISC) {
-		printf("%s: invalid creator id: %08x\n", __func__,
-		    ntohl(sp->creatorid));
+	if (sp->creatorid == 0) {
+		if (V_pf_status.debug >= PF_DEBUG_MISC)
+			printf("%s: invalid creator id: %08x\n", __func__,
+			    ntohl(sp->creatorid));
 		return (EINVAL);
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305111757.r4BHvqKu095997>