Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2026 09:34:21 +0000
From:      Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav <des@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Cc:        Aleksandr Rybalko <ray@FreeBSD.org>
Subject:   git: ce59deaf3540 - stable/14 - install: Bump compare size limit (128MB) to support large binaries
Message-ID:  <6a68779d.1be71.5ee9f236@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/14 has been updated by des:

URL: https://cgit.FreeBSD.org/src/commit/?id=ce59deaf3540a44f0414bf6deb2288b23f10d02b

commit ce59deaf3540a44f0414bf6deb2288b23f10d02b
Author:     Aleksandr Rybalko <ray@FreeBSD.org>
AuthorDate: 2026-05-27 12:07:47 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2026-07-28 09:31:16 +0000

    install: Bump compare size limit (128MB) to support large binaries
    
    Preserve metadata and prevent redundant disk writes during builds with
    the install's -C (compare) flag.
    
    The previous historical comparison limit of 16MB is insufficient for
    modern toolchains, frequently choked or bypassed by a large base
    components like LLVM/Clang, kernels, Rust apps, and large runtime
    libraries.
    
    By leaving matching files alone, install keeps their modification timestamps
    intact. make(1) safely ignores those files on subsequent runs.
    
    Base examples: 15.0 amd64 GENERIC kernel - 28MB, clang - 105MB, lldb - 97MB, etc.
    
    Reviewed by:    glebius
    Approved by:    glebius (mentor)
    Obtained from:  Fudo Security
    MFC after:      2 weeks
    Sponsored by:   Fudo Security
    Differential Revision:  https://reviews.freebsd.org/D57271
    
    (cherry picked from commit 5a8e0e03ae86b449f29626b4f9db25d17c89b273)
---
 usr.bin/xinstall/xinstall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/usr.bin/xinstall/xinstall.c b/usr.bin/xinstall/xinstall.c
index 7bb9ad15fc45..562632c523e8 100644
--- a/usr.bin/xinstall/xinstall.c
+++ b/usr.bin/xinstall/xinstall.c
@@ -101,7 +101,7 @@ static char sccsid[] = "@(#)xinstall.c	8.1 (Berkeley) 7/21/93";
 #define HAVE_STRUCT_STAT_ST_FLAGS 0
 #endif
 
-#define MAX_CMP_SIZE	(16 * 1024 * 1024)
+#define MAX_CMP_SIZE	(128 * 1024 * 1024)
 
 #define	LN_ABSOLUTE	0x01
 #define	LN_RELATIVE	0x02


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a68779d.1be71.5ee9f236>