Date: Fri, 29 Jun 2012 10:58:52 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: George Neville-Neil <gnn@neville-neil.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, obrien@FreeBSD.org Subject: Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c... Message-ID: <1340992732.19144.YahooMailClassic@web113501.mail.gq1.yahoo.com> In-Reply-To: <FDE692FD-8E3B-47A5-80A3-7327135A7725@neville-neil.com>
index | next in thread | previous in thread | raw e-mail
--- Ven 29/6/12, George Neville-Neil <gnn@neville-neil.com> ha scritto: > Da: George Neville-Neil <gnn@neville-neil.com> > Oggetto: Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c... > A: pfg@freebsd.org > Cc: obrien@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org > Data: Venerd́ 29 giugno 2012, 12:47 > > On Jun 29, 2012, at 13:35 , Pedro Giffuni wrote: > > > (Sorry for top-posting] > > > > Actually ... > > > > David pointed out a fundamental flaw on my part. > > > > These are new files under a non-BSD license. Even when > > they are only scripts used for testing I shouldn't > have > > brought them in without -core approval. > > > > I will delete them right away and core shall decide > > afterwards if and how they can be brought in. > > > > Are the files under a CDDL license? Since that's the > point of where you added them I don't think that that > should be an issue. The issue comes when we might > ship CDDL code by default, but these are tests and so that > should not be a problem. > They are under CDDL. I re-read the committer's guide and they are right where they are. Now .. David pointed out I am not respecting the code provenance since I didn't add them to the opensolaris vendor area, but these files are copyrighted Joyent Inc (not even Illumos) so I cannot put them there unless we create a new vendor for Joyent. As George notes, they are only test files so we can live without them if this is too much mess. Pedro.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340992732.19144.YahooMailClassic>