Date: Thu, 7 Jan 2021 08:24:02 -0700 From: Warner Losh <imp@bsdimp.com> To: Kyle Evans <kevans@freebsd.org> Cc: Peter Jeremy <peter@rulingia.com>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ac5f382a9d0a - main - stand: properly declare subdir deps or .WAIT, do parallel build Message-ID: <CANCZdfqA6uxaN9f2y%2BBWRpFZKTANeM0syXLXp46EWMbAqho82Q@mail.gmail.com> In-Reply-To: <CACNAnaGcqO7TYHFxn0H1=QHKDRNBqdH6S7%2BG2S_migxyY_%2BrmQ@mail.gmail.com> References: <202012311717.0BVHHp4G092948@gitrepo.freebsd.org> <X/a9GyfJzAhr1M8I@server.rulingia.com> <CACNAnaGcqO7TYHFxn0H1=QHKDRNBqdH6S7%2BG2S_migxyY_%2BrmQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 7, 2021, 6:34 AM Kyle Evans <kevans@freebsd.org> wrote: > On Thu, Jan 7, 2021 at 1:50 AM Peter Jeremy <peter@rulingia.com> wrote: > > > > On 2020-Dec-31 17:17:51 +0000, Kyle Evans <kevans@FreeBSD.org> wrote: > > >The branch main has been updated by kevans: > > > > > >URL: > https://cgit.FreeBSD.org/src/commit/?id=ac5f382a9d0a26685b92b49abb845d3b30ea5f91 > > > > > >commit ac5f382a9d0a26685b92b49abb845d3b30ea5f91 > > >Author: Kyle Evans <kevans@FreeBSD.org> > > >AuthorDate: 2020-12-31 17:15:45 +0000 > > >Commit: Kyle Evans <kevans@FreeBSD.org> > > >CommitDate: 2020-12-31 17:15:45 +0000 > > > > This commit adds fdt as a hard dependency for efi but leaves fdt as > > optionally built based on WITH_FDT. As a result, adding WITHOUT_FDT=yes > > causes the build to fail: > > make[3]: don't know how to make all_subdir_stand/fdt. Stop > > > > Either MK_FDT needs to be forced on by MK_EFI or the dependency needs to > > be made conditional. > > > > Ah, yes, sorry- will fix. It looks like that should be the only other > conditional dep that I missed here. The latter option is what we opt > for here- > We should add the missing items in our test matrix for tools/boot/universe.sh Warner Thanks, > > Kyle Evans >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqA6uxaN9f2y%2BBWRpFZKTANeM0syXLXp46EWMbAqho82Q>