Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Aug 2011 23:36:04 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r224643 - user/adrian/if_ath_tx/sys/dev/ath
Message-ID:  <201108032336.p73Na4W6034906@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Wed Aug  3 23:36:04 2011
New Revision: 224643
URL: http://svn.freebsd.org/changeset/base/224643

Log:
  Hold the ath_node lock when doing TX completion so the rate control code doesn't trample over itself.

Modified:
  user/adrian/if_ath_tx/sys/dev/ath/if_ath.c

Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c
==============================================================================
--- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Wed Aug  3 20:21:52 2011	(r224642)
+++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Wed Aug  3 23:36:04 2011	(r224643)
@@ -4205,8 +4205,11 @@ ath_tx_processq(struct ath_softc *sc, st
 			 * Hand the descriptor to the rate control algorithm.
 			 */
 			if ((ts->ts_status & HAL_TXERR_FILT) == 0 &&
-			    (bf->bf_txflags & HAL_TXDESC_NOACK) == 0)
+			    (bf->bf_txflags & HAL_TXDESC_NOACK) == 0) {
+				ATH_NODE_LOCK(an);
 				ath_rate_tx_complete(sc, an, bf);
+				ATH_NODE_UNLOCK(an);
+			}
 		}
 
 		if (bf->bf_comp == NULL)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108032336.p73Na4W6034906>