Date: Mon, 29 Dec 2014 21:48:21 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 194672] [carp] Changing advskew to 0 from another value doesn't work Message-ID: <bug-194672-2472-fw3CkI4Vph@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194672-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-194672-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194672 Renato Botelho <garga@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |garga@FreeBSD.org Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --- Comment #1 from Renato Botelho <garga@FreeBSD.org> --- Looking into sys/netinet/ip_carp.c at line 1706: if (carpr.carpr_advskew > 0) { if (carpr.carpr_advskew >= 255) { error = EINVAL; break; } sc->sc_advskew = carpr.carpr_advskew; } It silently accepts 0 as a good value (no error returned) but it doesn't set sc->sc_advskew. Is it expected to work this way? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194672-2472-fw3CkI4Vph>