Date: Wed, 09 Oct 2002 22:50:04 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: twchan@singnet.com.sg Cc: current@FreeBSD.ORG Subject: Re: dc and PCMCIA still panic Message-ID: <20021009.225004.115563444.imp@bsdimp.com> In-Reply-To: <20021008125918.E67735-100000@zaapth.twnet.org> References: <20021007.220252.50068329.imp@bsdimp.com> <20021008125918.E67735-100000@zaapth.twnet.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20021008125918.E67735-100000@zaapth.twnet.org>
Chan Tur Wei <twchan@singnet.com.sg> writes:
: Testing for the condition avoids the fault but leaves the card unusable
: under -newcard.
:
: ======================================================================
: --- pccard_cis.c Tue Oct 8 13:04:34 2002
: +++ pccard_cis.c.new Tue Oct 8 13:04:01 2002
: @@ -152,6 +152,11 @@
: while (1) {
: /* get the tuple code */
:
: + if (tuple.ptr >= PCCARD_CIS_SIZE) {
: + ret = 1;
: + goto done;
: + }
: +
: tuple.code = pccard_cis_read_1(&tuple, tuple.ptr);
:
: /* two special-case tuples */
: ======================================================================
Unfortunately, I don't think that this is valid. A longlink to common
memory can legitimately be outside of this range.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021009.225004.115563444.imp>