Date: Wed, 23 Jan 2008 21:29:01 GMT From: John Birrell <jb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 133948 for review Message-ID: <200801232129.m0NLT172006143@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=133948 Change 133948 by jb@jb_freebsd1 on 2008/01/23 21:28:46 Enable a few more tests to reach 677. Separate some that don't work from ones I haven't got to so that a 'make ignore' will run the ones I'm yet to work on while not trying the ones that are known to ruin one's day. Affected files ... .. //depot/projects/dtrace/src/tools/test/dtrace/Makefile#14 edit Differences ... ==== //depot/projects/dtrace/src/tools/test/dtrace/Makefile#14 (text+ko) ==== @@ -57,33 +57,14 @@ ${TESTSRCDIR}/tst/common/assocs/err.D_OP_INCOMPAT.dupttype.d \ ${TESTSRCDIR}/tst/common/assocs/tst.orthogonality.d \ ${TESTSRCDIR}/tst/common/buffering/tst.cputime.ksh \ - ${TESTSRCDIR}/tst/common/buffering/tst.resize1.d \ - ${TESTSRCDIR}/tst/common/buffering/tst.resize2.d \ ${TESTSRCDIR}/tst/common/buffering/tst.ring3.d \ - ${TESTSRCDIR}/tst/common/builtinvar/err.D_XLATE_NOCONV.cpuusage.d \ - ${TESTSRCDIR}/tst/common/builtinvar/err.D_XLATE_NOCONV.nice.d \ - ${TESTSRCDIR}/tst/common/builtinvar/err.D_XLATE_NOCONV.priority.d \ - ${TESTSRCDIR}/tst/common/builtinvar/err.D_XLATE_NOCONV.prsize.d \ - ${TESTSRCDIR}/tst/common/builtinvar/err.D_XLATE_NOCONV.rssize.d \ - ${TESTSRCDIR}/tst/common/builtinvar/tst.arg0clause.d \ - ${TESTSRCDIR}/tst/common/builtinvar/tst.arg1to8clause.d \ - ${TESTSRCDIR}/tst/common/builtinvar/tst.hpriority.d \ - ${TESTSRCDIR}/tst/common/builtinvar/tst.lwpsinfo.d \ - ${TESTSRCDIR}/tst/common/builtinvar/tst.lwpsinfo1.d \ ${TESTSRCDIR}/tst/common/builtinvar/tst.psinfo.d \ ${TESTSRCDIR}/tst/common/builtinvar/tst.psinfo1.d \ ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_AGGREGATION.d \ - ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_DBLERROR.d \ - ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_DYNAMIC.d \ - ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_PRINCIPAL.d \ - ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_PRINCIPAL.end.d \ - ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_SPEC.d \ - ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_SPECUNAVAIL.d \ ${TESTSRCDIR}/tst/common/drops/drp.DTRACEDROP_STKSTROVERFLOW.d \ ${TESTSRCDIR}/tst/common/dtraceUtil/err.D_PDESC_ZERO.InvalidDescription1.d \ ${TESTSRCDIR}/tst/common/dtraceUtil/tst.DestructWithModule.d.ksh \ ${TESTSRCDIR}/tst/common/dtraceUtil/tst.PreprocessorStatement.d.ksh \ - ${TESTSRCDIR}/tst/common/dtraceUtil/tst.ZeroModuleProbes.d.ksh \ ${TESTSRCDIR}/tst/common/funcs/err.D_PROTO_ARG.mobadarg.d \ ${TESTSRCDIR}/tst/common/funcs/err.D_PROTO_LEN.motoofew.d \ ${TESTSRCDIR}/tst/common/funcs/err.D_PROTO_LEN.motoomany.d \ @@ -106,31 +87,10 @@ ${TESTSRCDIR}/tst/common/funcs/tst.mutex_owned.d \ ${TESTSRCDIR}/tst/common/funcs/tst.mutex_owner.d \ ${TESTSRCDIR}/tst/common/funcs/tst.mutex_type_adaptive.d \ - ${TESTSRCDIR}/tst/common/funcs/tst.progenyof.d \ ${TESTSRCDIR}/tst/common/inline/err.D_OP_INCOMPAT.badxlate.d \ ${TESTSRCDIR}/tst/common/inline/tst.InlineDataAssign.d \ ${TESTSRCDIR}/tst/common/inline/tst.InlineExpression.d \ ${TESTSRCDIR}/tst/common/inline/tst.InlineTypedef.d \ - ${TESTSRCDIR}/tst/common/io/tst.fds.d \ - ${TESTSRCDIR}/tst/common/java_api/tst.Abort.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.Bean.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.Close.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.Drop.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.Enable.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.FunctionLookup.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.MaxConsumers.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.MultiAggPrinta.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.ProbeData.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.ProbeDescription.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.StateMachine.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.StopLock.ksh \ - ${TESTSRCDIR}/tst/common/java_api/tst.printa.d \ - ${TESTSRCDIR}/tst/common/lexer/err.D_CHR_NL.char.d \ - ${TESTSRCDIR}/tst/common/lexer/err.D_STR_NL.string.d \ - ${TESTSRCDIR}/tst/common/mdb/tst.dtracedcmd.ksh \ - ${TESTSRCDIR}/tst/common/mib/tst.icmp.ksh \ - ${TESTSRCDIR}/tst/common/mib/tst.tcp.ksh \ - ${TESTSRCDIR}/tst/common/mib/tst.udp.ksh \ ${TESTSRCDIR}/tst/common/misc/tst.dynopt.d \ ${TESTSRCDIR}/tst/common/misc/tst.include.ksh \ ${TESTSRCDIR}/tst/common/misc/tst.roch.d \ @@ -175,12 +135,10 @@ ${TESTSRCDIR}/tst/common/pointers/tst.basic1.d \ ${TESTSRCDIR}/tst/common/pointers/tst.basic2.d \ ${TESTSRCDIR}/tst/common/predicates/tst.argsnotcached.d \ - ${TESTSRCDIR}/tst/common/predicates/tst.predcache.ksh \ ${TESTSRCDIR}/tst/common/printa/tst.basics.d \ ${TESTSRCDIR}/tst/common/printa/tst.def.d \ ${TESTSRCDIR}/tst/common/printa/tst.dynwidth.d \ ${TESTSRCDIR}/tst/common/printa/tst.fmt.d \ - ${TESTSRCDIR}/tst/common/printa/tst.many.d \ ${TESTSRCDIR}/tst/common/printa/tst.manyval.d \ ${TESTSRCDIR}/tst/common/printa/tst.stack.d \ ${TESTSRCDIR}/tst/common/printa/tst.tuple.d \ @@ -193,7 +151,6 @@ ${TESTSRCDIR}/tst/common/privs/tst.func_access.ksh \ ${TESTSRCDIR}/tst/common/privs/tst.op_access.ksh \ ${TESTSRCDIR}/tst/common/proc/tst.discard.ksh \ - ${TESTSRCDIR}/tst/common/proc/tst.exitkilled.ksh \ ${TESTSRCDIR}/tst/common/proc/tst.signal.ksh \ ${TESTSRCDIR}/tst/common/proc/tst.sigwait.d \ ${TESTSRCDIR}/tst/common/proc/tst.startexit.ksh \ @@ -210,44 +167,6 @@ ${TESTSRCDIR}/tst/common/rates/tst.aggrate.d \ ${TESTSRCDIR}/tst/common/rates/tst.statusrate.d \ ${TESTSRCDIR}/tst/common/rates/tst.switchrate.d \ - ${TESTSRCDIR}/tst/common/safety/tst.basename.d \ - ${TESTSRCDIR}/tst/common/safety/tst.caller.d \ - ${TESTSRCDIR}/tst/common/safety/tst.cleanpath.d \ - ${TESTSRCDIR}/tst/common/safety/tst.copyin.d \ - ${TESTSRCDIR}/tst/common/safety/tst.copyin2.d \ - ${TESTSRCDIR}/tst/common/safety/tst.ddi_pathname.d \ - ${TESTSRCDIR}/tst/common/safety/tst.dirname.d \ - ${TESTSRCDIR}/tst/common/safety/tst.errno.d \ - ${TESTSRCDIR}/tst/common/safety/tst.execname.d \ - ${TESTSRCDIR}/tst/common/safety/tst.gid.d \ - ${TESTSRCDIR}/tst/common/safety/tst.hton.d \ - ${TESTSRCDIR}/tst/common/safety/tst.index.d \ - ${TESTSRCDIR}/tst/common/safety/tst.msgdsize.d \ - ${TESTSRCDIR}/tst/common/safety/tst.msgsize.d \ - ${TESTSRCDIR}/tst/common/safety/tst.null.d \ - ${TESTSRCDIR}/tst/common/safety/tst.pid.d \ - ${TESTSRCDIR}/tst/common/safety/tst.ppid.d \ - ${TESTSRCDIR}/tst/common/safety/tst.progenyof.d \ - ${TESTSRCDIR}/tst/common/safety/tst.random.d \ - ${TESTSRCDIR}/tst/common/safety/tst.rw.d \ - ${TESTSRCDIR}/tst/common/safety/tst.shortstr.d \ - ${TESTSRCDIR}/tst/common/safety/tst.stack.d \ - ${TESTSRCDIR}/tst/common/safety/tst.stackdepth.d \ - ${TESTSRCDIR}/tst/common/safety/tst.strchr.d \ - ${TESTSRCDIR}/tst/common/safety/tst.strjoin.d \ - ${TESTSRCDIR}/tst/common/safety/tst.strstr.d \ - ${TESTSRCDIR}/tst/common/safety/tst.strtok.d \ - ${TESTSRCDIR}/tst/common/safety/tst.substr.d \ - ${TESTSRCDIR}/tst/common/safety/tst.ucaller.d \ - ${TESTSRCDIR}/tst/common/safety/tst.uid.d \ - ${TESTSRCDIR}/tst/common/safety/tst.unalign.d \ - ${TESTSRCDIR}/tst/common/safety/tst.uregs.d \ - ${TESTSRCDIR}/tst/common/safety/tst.ustack.d \ - ${TESTSRCDIR}/tst/common/safety/tst.ustackdepth.d \ - ${TESTSRCDIR}/tst/common/safety/tst.vahole.d \ - ${TESTSRCDIR}/tst/common/safety/tst.violentdeath.ksh \ - ${TESTSRCDIR}/tst/common/safety/tst.zonename.d \ - ${TESTSRCDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupgtype.d \ ${TESTSRCDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupltype.d \ ${TESTSRCDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupttype.d \ ${TESTSRCDIR}/tst/common/scalars/tst.misc.d \ @@ -369,6 +288,70 @@ ${TESTSRCDIR}/tst/common/types/tst.ptrops.d \ ${TESTSRCDIR}/tst/common/types/tst.struct.d \ ${TESTSRCDIR}/tst/common/types/tst.typedef.d \ + ${TESTSRCDIR}/tst/common/vars/tst.gid.d \ + ${TESTSRCDIR}/tst/common/vars/tst.ppid.d \ + ${TESTSRCDIR}/tst/common/vars/tst.ucaller.ksh \ + ${TESTSRCDIR}/tst/common/vars/tst.uid.d \ + ${TESTSRCDIR}/tst/common/vars/tst.walltimestamp.d \ + +NOTWORK+= \ + ${TESTSRCDIR}/tst/common/io/tst.fds.d \ + ${TESTSRCDIR}/tst/common/java_api/tst.Abort.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.Bean.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.Close.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.Drop.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.Enable.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.FunctionLookup.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.MaxConsumers.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.MultiAggPrinta.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.ProbeData.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.ProbeDescription.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.StateMachine.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.StopLock.ksh \ + ${TESTSRCDIR}/tst/common/java_api/tst.printa.d \ + ${TESTSRCDIR}/tst/common/lexer/err.D_CHR_NL.char.d \ + ${TESTSRCDIR}/tst/common/lexer/err.D_STR_NL.string.d \ + ${TESTSRCDIR}/tst/common/mdb/tst.dtracedcmd.ksh \ + ${TESTSRCDIR}/tst/common/mib/tst.icmp.ksh \ + ${TESTSRCDIR}/tst/common/mib/tst.tcp.ksh \ + ${TESTSRCDIR}/tst/common/mib/tst.udp.ksh \ + ${TESTSRCDIR}/tst/common/safety/tst.basename.d \ + ${TESTSRCDIR}/tst/common/safety/tst.caller.d \ + ${TESTSRCDIR}/tst/common/safety/tst.cleanpath.d \ + ${TESTSRCDIR}/tst/common/safety/tst.copyin.d \ + ${TESTSRCDIR}/tst/common/safety/tst.copyin2.d \ + ${TESTSRCDIR}/tst/common/safety/tst.ddi_pathname.d \ + ${TESTSRCDIR}/tst/common/safety/tst.dirname.d \ + ${TESTSRCDIR}/tst/common/safety/tst.errno.d \ + ${TESTSRCDIR}/tst/common/safety/tst.execname.d \ + ${TESTSRCDIR}/tst/common/safety/tst.gid.d \ + ${TESTSRCDIR}/tst/common/safety/tst.hton.d \ + ${TESTSRCDIR}/tst/common/safety/tst.index.d \ + ${TESTSRCDIR}/tst/common/safety/tst.msgdsize.d \ + ${TESTSRCDIR}/tst/common/safety/tst.msgsize.d \ + ${TESTSRCDIR}/tst/common/safety/tst.null.d \ + ${TESTSRCDIR}/tst/common/safety/tst.pid.d \ + ${TESTSRCDIR}/tst/common/safety/tst.ppid.d \ + ${TESTSRCDIR}/tst/common/safety/tst.progenyof.d \ + ${TESTSRCDIR}/tst/common/safety/tst.random.d \ + ${TESTSRCDIR}/tst/common/safety/tst.rw.d \ + ${TESTSRCDIR}/tst/common/safety/tst.shortstr.d \ + ${TESTSRCDIR}/tst/common/safety/tst.stack.d \ + ${TESTSRCDIR}/tst/common/safety/tst.stackdepth.d \ + ${TESTSRCDIR}/tst/common/safety/tst.strchr.d \ + ${TESTSRCDIR}/tst/common/safety/tst.strjoin.d \ + ${TESTSRCDIR}/tst/common/safety/tst.strstr.d \ + ${TESTSRCDIR}/tst/common/safety/tst.strtok.d \ + ${TESTSRCDIR}/tst/common/safety/tst.substr.d \ + ${TESTSRCDIR}/tst/common/safety/tst.ucaller.d \ + ${TESTSRCDIR}/tst/common/safety/tst.uid.d \ + ${TESTSRCDIR}/tst/common/safety/tst.unalign.d \ + ${TESTSRCDIR}/tst/common/safety/tst.uregs.d \ + ${TESTSRCDIR}/tst/common/safety/tst.ustack.d \ + ${TESTSRCDIR}/tst/common/safety/tst.ustackdepth.d \ + ${TESTSRCDIR}/tst/common/safety/tst.vahole.d \ + ${TESTSRCDIR}/tst/common/safety/tst.violentdeath.ksh \ + ${TESTSRCDIR}/tst/common/safety/tst.zonename.d \ ${TESTSRCDIR}/tst/common/usdt/argmap.d \ ${TESTSRCDIR}/tst/common/usdt/args.d \ ${TESTSRCDIR}/tst/common/usdt/forker.d \ @@ -400,45 +383,51 @@ ${TESTSRCDIR}/tst/common/ustack/tst.bigstack.d \ ${TESTSRCDIR}/tst/common/ustack/tst.depth.ksh \ ${TESTSRCDIR}/tst/common/ustack/tst.spin.ksh \ - ${TESTSRCDIR}/tst/common/vars/tst.gid.d \ - ${TESTSRCDIR}/tst/common/vars/tst.ppid.d \ - ${TESTSRCDIR}/tst/common/vars/tst.ucaller.ksh \ - ${TESTSRCDIR}/tst/common/vars/tst.uid.d \ - ${TESTSRCDIR}/tst/common/vars/tst.walltimestamp.d \ + +# -------------------------------------------------------------------------------- +# Tests that just don't complete (even to fail) at the moment... + +NOTWORK+= \ + ${TESTSRCDIR}/tst/common/dtraceUtil/tst.ZeroModuleProbes.d.ksh \ + ${TESTSRCDIR}/tst/common/printa/tst.many.d \ + ${TESTSRCDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupgtype.d \ # -------------------------------------------------------------------------------- # Tests that currently hang the system: -IGNORE+= \ +NOTWORK+= \ ${TESTSRCDIR}/tst/common/fbtprovider/tst.basic.d \ ${TESTSRCDIR}/tst/common/fbtprovider/tst.return.d \ ${TESTSRCDIR}/tst/common/grammar/tst.stmts.d \ ${TESTSRCDIR}/tst/common/misc/tst.enablerace.ksh \ - + ${TESTSRCDIR}/tst/common/predicates/tst.predcache.ksh \ + ${TESTSRCDIR}/tst/common/proc/tst.exitkilled.ksh \ # -------------------------------------------------------------------------------- # Interrupt priority isn't relevant on FreeBSD. -IGNORE+= ${TESTSRCDIR}/tst/common/builtinvar/tst.ipl.d \ +NOTWORK+= ${TESTSRCDIR}/tst/common/builtinvar/tst.ipl.d \ ${TESTSRCDIR}/tst/common/builtinvar/tst.ipl1.d # -------------------------------------------------------------------------------- # This test relies on the Solaris ping behaviour of exiting after a number of # pings. On FreeBSD ping doesn't do that. -IGNORE+= ${TESTSRCDIR}/tst/common/funcs/tst.system.d +NOTWORK+= ${TESTSRCDIR}/tst/common/funcs/tst.system.d # -------------------------------------------------------------------------------- # This test checks for a leading tab on a line before #define. That is illegal # on Solaris, but the gcc pre-processor on FreeBSD is happy with code like that. -IGNORE+= ${TESTSRCDIR}/tst/common/preprocessor/err.D_PRAGCTL_INVAL.tabdefine.d +NOTWORK+= ${TESTSRCDIR}/tst/common/preprocessor/err.D_PRAGCTL_INVAL.tabdefine.d # -------------------------------------------------------------------------------- # This test is coded to use Solaris syscall names. FreeBSD has none with 'lwp" # in them, so the test fails because of that. -IGNORE+= ${TESTSRCDIR}/tst/common/probes/tst.probestar.d +NOTWORK+= ${TESTSRCDIR}/tst/common/probes/tst.probestar.d + +NOTYET= ${IGNORE} ${NOTWORK} # -------------------------------------------------------------------------------- # Only prepare the test lists if we need to: @@ -470,9 +459,9 @@ ${_d}_TF= ${${_d}_ERR} ${${_d}_TST} ${${_d}_SHERR} ${${_d}_SHTST} # Go through the list of test files and prepare another list that contains -# none of the test files listed in the IGNORE list: +# none of the test files listed in the NOTYET list: .for _f in ${${_d}_TF} -.if (${IGNORE:M${_f}} == "") +.if (${NOTYET:M${_f}} == "") ${_d}_TFS+= ${_f} .endif .endfor @@ -493,7 +482,7 @@ # -------------------------------------------------------------------------------- # A target to build the tests flagged as not working yet: -notyet : +ignore : @${DTEST} ${IGNORE} .endif @@ -521,6 +510,7 @@ .BEGIN : @if ! kldstat -q -m dtrace_test; then kldload dtrace_test; fi + @sync; sync; sync; sync; sync .include <bsd.obj.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801232129.m0NLT172006143>