Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Nov 2017 09:46:23 +0100
From:      Mateusz Guzik <mjguzik@gmail.com>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        Mateusz Guzik <mjg@freebsd.org>,  "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r325266 - head/sys/kern
Message-ID:  <CAGudoHFt1BkHyrGsxGuJhwRRjR4Bi-WEOgA-eL8qw6MNLaDJzQ@mail.gmail.com>
In-Reply-To: <2c922b9b-cd6b-bb9a-00b8-97c137362769@selasky.org>
References:  <201711010645.vA16jf0E054903@repo.freebsd.org> <2c922b9b-cd6b-bb9a-00b8-97c137362769@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 1, 2017 at 9:41 AM, Hans Petter Selasky <hps@selasky.org> wrote:

> On 11/01/17 07:45, Mateusz Guzik wrote:
>
>> +static u_long __read_mostly    ncnegfactor = 12; /* ratio of negative
>> entries */
>>   SYSCTL_ULONG(_vfs, OID_AUTO, ncnegfactor, CTLFLAG_RW, &ncnegfactor, 0,
>>       "Ratio of negative namecache entries");
>>
>
> Should this SYSCTL entry use CTLFLAG_RWTUN ?
>

I don't see why. Worst case some negative entries will be whacked before
someone's
sysctl.conf is being read OR some will live a little bit longer, depending
on which way
the change is made.

That said, feel free to change it if you want.

-- 
Mateusz Guzik <mjguzik gmail.com>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHFt1BkHyrGsxGuJhwRRjR4Bi-WEOgA-eL8qw6MNLaDJzQ>