Date: Mon, 31 May 2010 19:47:03 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: gnome@freebsd.org Subject: Re: ports/146885: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set Message-ID: <AANLkTimOZQ_ogVEGcx3YFH-VWSQ9OTyy0yWNJ8Q8rMZZ@mail.gmail.com> In-Reply-To: <4C0452D8.9000408@freebsd.org> References: <201005312120.o4VLKJMi078305@freefall.freebsd.org> <AANLkTilwwwTgipFMq1atDFmuROKkeb4JyR5ZvnEVQlR_@mail.gmail.com> <4C0452D8.9000408@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Mon, May 31, 2010 at 5:22 PM, Joe Marcus Clarke <marcus@freebsd.org> wrote:
> On 5/31/10 7:45 PM, Garrett Cooper wrote:
>> On Mon, May 31, 2010 at 2:20 PM, <marcus@freebsd.org> wrote:
>>> Synopsis: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set
>>>
>>> State-Changed-From-To: open->feedback
>>> State-Changed-By: marcus
>>> State-Changed-When: Mon May 31 21:17:12 UTC 2010
>>> State-Changed-Why:
>>> I don't see the bug. First, we _should_ be checking for libcups in ${LOCALBASE}
>>> and not ${PREFIX}. The other changes just look to be aesthetic.
>>
>> They're not. := is acceptable for deferred make variables... not
>> for the plist stuff (was this ever functional?).
>
> Yes, that's functional and perfectly allowed. The ":=" in this notation
> is just acting as a label (the label being "CUPS:"). There are other
> ports which use this same notation.
Why does my version pass then when cups isn't installed :)?
Thanks,
-Garrett
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimOZQ_ogVEGcx3YFH-VWSQ9OTyy0yWNJ8Q8rMZZ>