Date: Fri, 24 Oct 2008 10:31:07 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: marcel@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, Dag-Erling Sm??rgrav <des@des.no>, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf Message-ID: <200810241031.08780.jhb@freebsd.org> In-Reply-To: <20081024132703.GA81378@FreeBSD.org> References: <200810230151.m9N1ptUe044619@svn.freebsd.org> <868wsewzos.fsf@ds4.des.no> <20081024132703.GA81378@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 24 October 2008 09:27:03 am Alexey Dokuchaev wrote: > On Fri, Oct 24, 2008 at 03:26:43AM +0200, Dag-Erling Sm??rgrav wrote: > > Warner Losh <imp@bsdimp.com> writes: > > > We already have a better mechanism for including config files. We > > > should be using that instead of poluting another port with the > > > DEFAULTS file. > > > > Should we even have DEFAULTS files at all? IMHO they just confuse > > matters by introducing "stealth" options into your config. > > I tend to second this. I always try to get everything possible out of > my kernel to modules, and thus was surprised to see io.ko and mem.ko > fail to load because they were silently included into my custom kernel. > > I understand that some things like 'device isa' and > 'device npx' aren't really optional, but if something is useful to have, > but can be loaded as a module, it belongs to GENERIC rather than > DEFAULTS. Killing the latter altogether and throwing a comment that > says particular option or device is mandatory in GENERIC is probably > even better (and more transparent). The one thing I think DEFAULTS is useful for are replacing NO_FOO options with FOO options. That is, if someone wants to turn a feature on by default, I'd rather them put 'options FOO' in DEFAULTS rather than rename all the #ifdef's,e tc. to '#ifndef NO_FOO'. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810241031.08780.jhb>