Date: Fri, 7 Feb 2014 11:14:17 -0700 From: Alan Somers <asomers@freebsd.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r261604 - head/contrib/libc++/include Message-ID: <CAOtMX2hcxk0Ff5YBVBHc-qS5jwVseipwJig1GJCyYijwroFS0A@mail.gmail.com> In-Reply-To: <201402071810.s17IAZtx043815@svn.freebsd.org> References: <201402071810.s17IAZtx043815@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 7, 2014 at 11:10 AM, Eitan Adler <eadler@freebsd.org> wrote: > Author: eadler > Date: Fri Feb 7 18:10:34 2014 > New Revision: 261604 > URL: http://svnweb.freebsd.org/changeset/base/261604 > > Log: > HEAD is not buildable for the past day. Commit a 'quick fix' in order to permit > buildworld to complete. > > Reviewed by: theraven > > Modified: > head/contrib/libc++/include/locale Are you sure that this will work on all architectures? It implicitly assumes that ptrdiff_t is the same as long. IMHO, it's better to cast the left side of the comparison to size_t, because it will always be nonnegative as long as __a_end is greater than or equal to __a. They certainly sound like it, based on the names. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2hcxk0Ff5YBVBHc-qS5jwVseipwJig1GJCyYijwroFS0A>