Date: Sun, 7 Jul 2002 09:00:23 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 13866 for review Message-ID: <200207071600.g67G0Nj3063151@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=13866 Change 13866 by rwatson@rwatson_paprika on 2002/07/07 08:59:26 Apparently whoever decided to stick SAVENAME into the namei() arguments all over vfs_syscalls.c forgot that SAVENAME wasn't an operation, it's a flag, resulting in a panic on calls to mkfifo(). Someone remind me why we've added SAVENAME all over the place anyway, it results in a lot of diffs and I'm not sure we're using it. Affected files ... .. //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#48 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#48 (text+ko) ==== @@ -1977,7 +1977,7 @@ restart: bwillwrite(); - NDINIT(&nd, CREATE | SAVENAME, LOCKPARENT, UIO_USERSPACE, + NDINIT(&nd, CREATE, LOCKPARENT | SAVENAME, UIO_USERSPACE, SCARG(uap, path), td); if ((error = namei(&nd)) != 0) return (error); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207071600.g67G0Nj3063151>