Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 May 2007 18:26:52 GMT
From:      Fredrik Lindberg <fli@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 119680 for review
Message-ID:  <200705111826.l4BIQqrU011714@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=119680

Change 119680 by fli@fli_genesis on 2007/05/11 18:26:40

	Fix faulty assert logic.

Affected files ...

.. //depot/projects/soc2007/fli-mdns_sd/mdnsd/stack_buf.c#4 edit
.. //depot/projects/soc2007/fli-mdns_sd/mdnsd/stack_packet.c#4 edit

Differences ...

==== //depot/projects/soc2007/fli-mdns_sd/mdnsd/stack_buf.c#4 (text+ko) ====

@@ -44,9 +44,7 @@
 {
 	struct mdns_bufpool *bp;
 
-	assert((lock != NULL && unlock == NULL) ||
-		(lock == NULL && unlock != NULL) ||
-		(lock == NULL && unlock == NULL));
+	assert((lock == NULL && unlock == NULL) || (lock != unlock));
 
 	bp = malloc(sizeof(struct mdns_bufpool));
 	bzero(bp, sizeof(struct mdns_bufpool));

==== //depot/projects/soc2007/fli-mdns_sd/mdnsd/stack_packet.c#4 (text+ko) ====

@@ -121,9 +121,7 @@
 	int flags, md_lock lock, md_unlock unlock, void *arg)
 {
 
-	assert((lock != NULL && unlock == NULL) ||
-		(lock == NULL && unlock != NULL) ||
-		(lock == NULL && unlock == NULL));
+	assert((lock == NULL && unlock == NULL) || (lock != unlock));
 
 	pc->pc_md = md;
 	pc->pc_lock = lock;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200705111826.l4BIQqrU011714>