Date: Fri, 10 May 2013 13:36:37 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r250430 - head/sbin/dmesg Message-ID: <20130510133637.GA1679@FreeBSD.org> In-Reply-To: <CAF6rxgkHDzMPY7za8z--SSPz3VJGisM_nT96CX9xxKvU4h5TxA@mail.gmail.com> References: <201305100342.r4A3gmc9080595@svn.freebsd.org> <20130510074235.GA19945@FreeBSD.org> <CAF6rxgkHDzMPY7za8z--SSPz3VJGisM_nT96CX9xxKvU4h5TxA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 10, 2013 at 08:43:37AM -0400, Eitan Adler wrote: > On 10 May 2013 03:42, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Fri, May 10, 2013 at 03:42:48AM +0000, Eitan Adler wrote: > >> New Revision: 250430 > >> URL: http://svnweb.freebsd.org/changeset/base/250430 > >> > >> (void) setlocale(LC_CTYPE, ""); > > > > It's a bit weird that you've left the cast here... > > I didn't modify this line OK. > >> - (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n"); > >> + fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n"); > > > > but removed it here for no particular reason. > > Notice the additional 'c' in usage(). Of course. But my question was about dropping the cast, not adding new option. Adding a new option should have resulted in the following diff: - (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n"); + (void)fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n"); ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130510133637.GA1679>