Date: Sat, 8 Nov 2003 01:55:16 -0800 (PST) From: Bruce Evans <bde@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/bin/rm rm.c Message-ID: <200311080955.hA89tGiP048748@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
bde 2003/11/08 01:55:16 PST
FreeBSD src repository
Modified files:
bin/rm rm.c
Log:
1. Fixed leakage of a file descriptor for every non-fatal failure in
rm_overwrite() (for rm -P).
2. Print the file name in the error message for (fatal) malloc() failures
in rm_overwrite(). I first thought that malloc() failures should be
non-fatal since they don't prevent proceeding the the next file, but
making them non-fatal would normally give too much output for rm -Pr
on a large tree in the unlikely event that even one occurs, since the
malloc()ed amounts are usually the same. Just print the file name since
the malloc()ed amounts are not always the same and it doesn't hurt to
know where rm was when it quit.
Submitted by: guido ((1) and original version of (2))
Revision Changes Path
1.44 +3 -1 src/bin/rm/rm.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311080955.hA89tGiP048748>