Date: Thu, 13 Jun 1996 02:00:02 -0700 (PDT) From: Gennady Sorokopud <gena@NetVision.net.il> To: freebsd-bugs Subject: Re: bin/1320: dump limits blocksize to 32K Message-ID: <199606130900.CAA07045@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/1320; it has been noted by GNATS.
From: Gennady Sorokopud <gena@NetVision.net.il>
To: "Gary Palmer" <gpalmer@FreeBSD.ORG>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/1320: dump limits blocksize to 32K
Date: Thu, 13 Jun 1996 11:59:25 +0200 (IST)
Hello!
On 13-Jun-96 "Gary Palmer" wrote:
[skip]
>Your patch is wrong for just that reason ... it is true for local
>backups, and removing the code which does the check is hence
>incorrect. It should only ignore the blocksize for non-local backups,
>not ignore it totally.
Oh well, i though that local backups will work with this as well
and 32 is just some ancient limit.
Anyway , try this one:
*** main.c.org Thu Jun 13 11:14:12 1996
--- main.c Thu Jun 13 11:57:36 1996
***************
*** 167,179 ****
case 'b': /* blocks per tape write */
ntrec =3D numarg('b', "number of blocks per write",
1L, 1000L, &argc, &argv);
- /* XXX restore is unable to restore dumps that=20
- were created with a blocksize larger than 32K.
- Possibly a bug in the scsi tape driver. */
- if ( ntrec > 32 ) {
- msg("please choose a blocksize <=3D 32\n");
- exit(X_ABORT);
- }
break;
=20
case 'B': /* blocks per output file */
--- 167,172 ----
***************
*** 263,268 ****
--- 256,271 ----
exit(X_ABORT);
#endif
}
+ else {
+ /* XXX restore is unable to restore dumps that=20
+ were created with a blocksize larger than 32K.
+ Possibly a bug in the scsi tape driver. */
+ if ( ntrec > 32 ) {
+ msg("please choose a blocksize <=3D 32\n");
+ exit(X_ABORT);
+ }
+ }
+=20
(void)setuid(getuid()); /* rmthost() is the only reason to be setuid */
=20
if (signal(SIGHUP, SIG_IGN) !=3D SIG_IGN)
>
>Gary
>--
>Gary Palmer FreeBSD Core Team Member
>FreeBSD: Turning PC's into workstations. See http://www.FreeBSD.ORG/ for info
Best regards.
--------
Gennady B. Sorokopud - System programmer at NetVision Israel.
E-Mail: Gennady Sorokopud <gena@NetVision.net.il>
Homepage: http://www.netvision.net.il/~gena
This message was sent at 06/13/96 11:59:25 by XF-Mail
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199606130900.CAA07045>