Date: Wed, 27 Mar 2002 19:29:59 -0500 (EST) From: Trevor Johnson <trevor@jpj.net> To: "David O'Brien" <obrien@FreeBSD.org> Cc: Trevor Johnson <trevor@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: ports/www/linux-mozilla Makefile Message-ID: <20020327192411.S6435-100000@blues.jpj.net> In-Reply-To: <20020327155542.A36674@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote: > On Wed, Mar 27, 2002 at 09:52:07AM -0800, Trevor Johnson wrote: > > trevor 2002/03/27 09:52:07 PST > > > > Modified files: > > www/linux-mozilla Makefile > > Log: > > Bump PORTREVISION for change to startup script. > > > > Change a space to a tab. > > This is the wrong use of PORTREVISION -- you are going to force users to > "upgrade" for only a space->tab change! PORTREVISION is for when there > is a functional difference before and after a commit that does not also > bump the PORTVERSION. > > Please review > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/x389.html#AEN393 You misread the commit log. The change to PORTREVISION is because of ("for") the recent change to the startup script, not because of the whitespace change. I forgot to do it earlier. The whitespace change is unrelated. I felt that a separate commit for it would be overkill, and a separate paragraph was sufficient. -- Trevor Johnson To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020327192411.S6435-100000>