Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Aug 2017 15:28:17 +0100
From:      Roger Pau Monn <royger@freebsd.org>
To:        Li-Wen Hsu <lwhsu@FreeBSD.org>
Cc:        Ed Maste <emaste@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r322347 - in head/sys/x86: acpica include x86 xen
Message-ID:  <20170811142817.vdcz5pzn45zild55@dhcp-3-128.uk.xensource.com>
In-Reply-To: <20170811101015.GA83032@freefall.freebsd.org>
References:  <201708100915.v7A9FIke002476@repo.freebsd.org> <CAPyFy2DdQe=BnHta7PDpF1vf7JQYSAkjfgjgYyoudrNdnY6snw@mail.gmail.com> <20170810174853.6xzxzxscm4cmd5vy@dhcp-3-128.uk.xensource.com> <20170811101015.GA83032@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 11, 2017 at 10:10:15AM +0000, Li-Wen Hsu wrote:
> On Thu, Aug 10, 2017 at 18:48:53 +0100, Roger Pau Monn wrote:
> > On Thu, Aug 10, 2017 at 10:20:59AM -0400, Ed Maste wrote:
> > > On 10 August 2017 at 05:15, Roger Pau Monné <royger@freebsd.org> wrote:
> > > > Author: royger
> > > > Date: Thu Aug 10 09:15:18 2017
> > > > New Revision: 322347
> > > > URL: https://svnweb.freebsd.org/changeset/base/322347
> > > >
> > > > Log:
> > > >   apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase
> > > 
> > > i386 is failing with:
> > 
> > Thanks for the heads up! Should be fixed in r322372, will keep an eye on
> > the CI.
> 
> It seems i386 LINT is still failing:
> 
> /workspace/src/sys/x86/acpica/srat.c:446:28: error: implicit declaration of function 'PHYS_TO_DMAP' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>         cpus = (struct cpu_info *)PHYS_TO_DMAP(addr);
>                                   ^
> 
> Could you also chcek this one? https://ci.freebsd.org/job/FreeBSD-head-i386-LINT/2833/console

Sorry again for the breakage, should be fixed in r322403. Not sure if
it makes much sense to parse the SRAT on i386 anyway.

Roger.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170811142817.vdcz5pzn45zild55>