Date: Sun, 22 Jul 2001 05:17:51 -0700 (PDT) From: Ian Dowse <iedowse@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sbin/umount umount.c src/usr.sbin/rpc.umntall mounttab.c mounttab.h rpc.umntall.c Message-ID: <200107221217.f6MCHpl23606@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
iedowse 2001/07/22 05:17:51 PDT
Modified files:
sbin/umount umount.c
usr.sbin/rpc.umntall mounttab.c mounttab.h rpc.umntall.c
Log:
Fix some bugs and general brain damage in mounttab:
- Declare mtabhead as an extern in mounttab.h and define it only in
mounttab.c.
- Remove shared global `verbose' and instead pass it as a parameter.
- Remove the `mtabp' argument to read_mtab(). It served no purpose
whatsoever, although read_mtab() did use it as a temporary local
variable.
- Don't check for impossible conditions when parsing mounttab, and
do detect zero-length fields.
- Correctly test for strtoul() failures - just testing ERANGE is wrong.
- Include a field name in syslog errors, and avoid passing NULL to
a syslog %s field.
- Don't test if arrays are NULL.
- If there are duplicates when writing out mounttab, keep the last
entry instead of the first, as it will have a later timestamp.
- Fix a few formatting issues.
Update rpc.umntall and umount to match the mounttab interface changes.
Revision Changes Path
1.27 +4 -5 src/sbin/umount/umount.c
1.4 +56 -58 src/usr.sbin/rpc.umntall/mounttab.c
1.2 +7 -6 src/usr.sbin/rpc.umntall/mounttab.h
1.7 +6 -7 src/usr.sbin/rpc.umntall/rpc.umntall.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107221217.f6MCHpl23606>