Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2025 20:38:56 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 6aa2c8ed5eef - stable/14 - TCP RACK: simplify condition
Message-ID:  <202502052038.515Kcu4p065527@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=6aa2c8ed5eef2572fbb64d9512067a9693c97116

commit 6aa2c8ed5eef2572fbb64d9512067a9693c97116
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-02 15:19:30 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 09:39:15 +0000

    TCP RACK: simplify condition
    
    It is already known that rsm != NULL, so no need to check for it.
    
    Reviewed by:            rrs
    CID:                    1523815
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48282
    
    (cherry picked from commit 8471791eb6eeedaedd4d70e1076cfd143bf12fca)
---
 sys/netinet/tcp_stacks/rack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c
index 9ac923ce760c..040e882e157a 100644
--- a/sys/netinet/tcp_stacks/rack.c
+++ b/sys/netinet/tcp_stacks/rack.c
@@ -19092,7 +19092,7 @@ rack_fast_rsm_output(struct tcpcb *tp, struct tcp_rack *rack, struct rack_sendma
 		log.u_bbr.pkts_out = tp->t_maxseg;
 		log.u_bbr.timeStamp = cts;
 		log.u_bbr.inflight = ctf_flight_size(rack->rc_tp, rack->r_ctl.rc_sacked);
-		if (rsm && (rsm->r_rtr_cnt > 0)) {
+		if (rsm->r_rtr_cnt > 0) {
 			/*
 			 * When we have a retransmit we want to log the
 			 * burst at send and flight at send from before.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502052038.515Kcu4p065527>