Date: Wed, 3 Aug 2005 13:32:08 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Alexander Leidinger <netchild@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, ru@FreeBSD.org, grehan@FreeBSD.org, des@des.no, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 Message-ID: <20050803113208.GG45385@obiwan.tataz.chchile.org> In-Reply-To: <20050803121150.gn025733y8400wk8@netchild.homeip.net> References: <20050731102343.35bc4aa9@Magellan.Leidinger.net> <20050802090717.GK14023@ip.net.ua> <20050802140536.zstn68rcgsg84g0w@netchild.homeip.net> <20050802.085239.34568854.imp@bsdimp.com> <20050803121150.gn025733y8400wk8@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Wed, Aug 03, 2005 at 12:11:50PM +0200, Alexander Leidinger wrote: > "M. Warner Losh" <imp@bsdimp.com> wrote: > > >In message: <20050802140536.zstn68rcgsg84g0w@netchild.homeip.net> > > Alexander Leidinger <netchild@FreeBSD.org> writes: > >: When an user calls delete-old with DESTDIR set to the root of a > >non-native > >: machine architecture he may remove non-obsolete files when he > >forgets to set > >: TARGET_ARCH. I want to prevent this situation. I think "failsafe" is more > >: important than "POLA" in this case. > > > >If TARGET_ARCH is set, then the right set of files will be deleted if > >you use TARGET_ARCH rather than MACHINE_ARCH. > > Yes. I'm not talking about technical problems. I talk about problems which > sit on a chair. If we change MACHINE_ARCH to TARGET_ARCH and an user runs > "make delete-old-libs" without setting TARGET_ARCH in a cross-arch > environment, he will remove non-obsolete libs. And I think we should go the > failsafe route. > > If you think we can life with this problem, go ahead and change MACHINE_ARCH > to TARGET_ARCH. But add an explanation to the commit log which makes it > obvious that you understand the problem I'm talking about and that we > (FreeBSD) don't care about it. And be prepared that I will whine at the > person which makes this change when someone shoots in his foot when he > forgets to set TARGET_ARCH. What about making TARGET_ARCH mandatory if DESTDIR is different from "/" ? Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050803113208.GG45385>