Date: Wed, 19 Jul 2017 11:10:33 +0200 From: Torsten Zuehlsdorff <tz@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r446066 - in head/databases: . postgresql-orafce Message-ID: <528d514b-463a-c3c4-2f9c-a031dcabc667@FreeBSD.org> In-Reply-To: <b727f21d-59ad-1375-4bd7-00d382de0537@FreeBSD.org> References: <201707171115.v6HBFqjc008876@repo.freebsd.org> <b727f21d-59ad-1375-4bd7-00d382de0537@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17.07.2017 16:45, Mathieu Arnold wrote:
> Le 17/07/2017 à 13:15, Torsten Zuehlsdorff a écrit :
>> +PLIST_FILES= lib/postgresql/orafce.so \
>> + %%PORTDOCS%%%%DOCSDIR%%/README.asciidoc \
>> + share/postgresql/extension/orafce--3.2--3.3.sql \
>> + share/postgresql/extension/orafce--3.3--3.4.sql \
>> + share/postgresql/extension/orafce--3.4.sql \
>> + share/postgresql/extension/orafce.control
>
> 1) remove the README.asciidoc from there, and add PORTDOCS=README.asciidoc
> 2) you never use %%foo%% placeholders in PLIST_FILES. The placeholders
> are necessary to carry variables from the Makefile to the plist file.
> In this case, you are in the Makefile, so you do not need to add one
> more level of indirection to use the placeholders.
>
> If you were dead set against using PORTDOCS, you could use:
>
> DOCS_PLIST_FILES= ${DOCSDIR}/README.asciidoc
Thank you for the explanation! I wasn't aware of this. Fixed in r446189.
Greetings,
Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?528d514b-463a-c3c4-2f9c-a031dcabc667>