Date: Wed, 4 Jul 2018 14:52:58 -0700 From: Eitan Adler <lists@eitanadler.com> To: Hiroki Sato <hrs@freebsd.org> Cc: daichigoto@icloud.com, Daichi GOTO <daichi@freebsd.org>, George Neville-Neil <gnn@freebsd.org>, "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335836 - head/usr.bin/top Message-ID: <CAF6rxgnm=Zps%2BQYZ4RuawHY-Q8PACzBiL2WvZy4zrb0_T6zX=w@mail.gmail.com> In-Reply-To: <20180705.013715.810854236306970666.hrs@allbsd.org> References: <20180702.155529.1102410939281120947.hrs@allbsd.org> <459BD898-8072-426E-A968-96C1382AC616@icloud.com> <20180703.020956.859981414196673670.hrs@allbsd.org> <20180705.013715.810854236306970666.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 4 Jul 2018 at 09:41, Hiroki Sato <hrs@freebsd.org> wrote: > > Are you going to back out r335836, or disagree about it? > > If there is no objection in the next 24 hours, I will commit the > attached patch. This should be a minimal change to support multibyte > characters in ARGV array depending on LC_CTYPE, not limited to UTF-8. Based on this conversation and my otherwise minimal knowledge about software localization this LGTM. Thanks! -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnm=Zps%2BQYZ4RuawHY-Q8PACzBiL2WvZy4zrb0_T6zX=w>