Date: Thu, 23 Oct 2008 17:18:42 +0200 From: "=?ISO-8859-1?Q?Marius_N=FCnnerich?=" <marius@nuenneri.ch> To: "Ivan Voras" <ivoras@freebsd.org> Cc: freebsd-geom@freebsd.org Subject: Re: [PATCH] Teach geom_label to recognise gpt labels and uuids Message-ID: <b649e5e0810230818n7a80033atb9be624d0f8f8398@mail.gmail.com> In-Reply-To: <b649e5e0810230501g2b2e8ee0iaa66388ed767e69c@mail.gmail.com> References: <b649e5e0810230412u5a80ddb8p3955d5b052fa1896@mail.gmail.com> <gdpnsf$8s2$1@ger.gmane.org> <b649e5e0810230501g2b2e8ee0iaa66388ed767e69c@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 23, 2008 at 2:01 PM, Marius N=FCnnerich <marius@nuenneri.ch> wr= ote: > On Thu, Oct 23, 2008 at 1:41 PM, Ivan Voras <ivoras@freebsd.org> wrote: >> Marius N=FCnnerich wrote: >>> Hi all, >>> >>> I wrote the following patch for geom_label: >>> http://nuenneri.ch/freebsd/geom_label.patch >>> >>> What do you think about it? I would love to hear about some tests. >> >> Do you think it's wise to have two separate directories: /dev/gpt and >> /dev/gpt_uuid? I don't think anyone will mistake the UUID from the label >> if it's in the same directory. Also, if I remember correctly how GPT >> works, UUID is always present but the label is optional? > > The label can only be 18 characters long and a uuid is always longer > than that, so that shouldn't be a problem. Actually it's just an > implementation detail because I couldn't add two /dev entries in one > taste. I will think about how I could create both entries in one > directory (if the label is set). Ok, I updated the patch. It's now just /dev/gpt. I think I'll collapse the two files into one. Thanks for your feedback so far.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b649e5e0810230818n7a80033atb9be624d0f8f8398>