Date: Fri, 8 Aug 2003 13:01:05 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Andrew Turner <zombie@i4free.co.nz> Cc: Nate Lawson <nate@root.org> Subject: Re: Warning with loader Makefile? Message-ID: <20030808100105.GB40307@sunbay.com> In-Reply-To: <3F32DFFD.4060402@i4free.co.nz> References: <20030807074557.S75796@root.org> <3F32DFFD.4060402@i4free.co.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Aug 08, 2003 at 11:25:49AM +1200, Andrew Turner wrote:
[...]
> I found this patch worked by removing the secound ${PROG} target if
> there was already one there.
>
> --- /usr/src/share/mk/bsd.prog.mk Mon Jun 30 06:16:26 2003
> +++ /usr/share/mk/bsd.prog.mk Mon Aug 4 17:54:22 2003
> @@ -31,11 +31,13 @@
>
> OBJS+= ${SRCS:N*.h:R:S/$/.o/g}
>
> +.if !target(${PROG})
> ${PROG}: ${OBJS}
> .if defined(PROG_CXX)
> ${CXX} ${CXXFLAGS} ${LDFLAGS} -o ${.TARGET} ${OBJS} ${LDADD}
> .else
> ${CC} ${CFLAGS} ${LDFLAGS} -o ${.TARGET} ${OBJS} ${LDADD}
> +.endif
> .endif
>
> .else !defined(SRCS)
No, thanks. If a makefile has a
${PROG}: foo
line, just to add an additional dependency, this patch will break
building the ${PROG}.
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE/M3TgUkv4P6juNwoRAlLTAJ9Qj9B+tpX76DLGhUlrzVfRUHud2ACfdDoT
yZFH4CZ6HxPEVRu82l8eOw0=
=3oev
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030808100105.GB40307>