Date: Tue, 29 May 2012 20:16:55 -0500 From: Bryan Drewery <bryan@shatow.net> To: freebsd-hackers@freebsd.org Cc: ed@80386.nl, brucec@freebsd.org Subject: Re: script(1) broken on 7.4 - bin/146189 - r207453 fixes Message-ID: <4FC57507.8070008@shatow.net> In-Reply-To: <4FC2EBA5.8010500@shatow.net> References: <4FC2EBA5.8010500@shatow.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig25950D3E0AFAE1F9752655F5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 5/27/2012 10:06 PM, Bryan Drewery wrote: > Hi, >=20 > As reported in bin/146189, script(1) was returning the wrong exit statu= s > sometimes. >=20 > The PR says that script(1) was broken by r205008/r205635, neither of > which are in 7-stable or releng/7.4. Yet it is broken on 7.4. >=20 > This is easily seen on 7.4: >=20 > # script -q /dev/null false; echo $? > 1 > # script -q /dev/null false; echo $? > 1 > # script -q /dev/null false; echo $? > 0 > # script -q /dev/null false; echo $? > 1 > # while true; do script -q /dev/null false && echo $? && break; ech= o > $?; done > 1 > 1 > <..snip..> > 1 > 0 >=20 > r207453 was MFC'd to 8-stable at the time, but not 7-stable, likely due= > to the changes attributed to causing the issue not having been on 7-sta= ble. >=20 > I am not entirely sure *how* script(1) broke on 7.4, but I have tested > r207453 on 7.4 and found that it Works For Me. >=20 > FWIW, could someone please MFC this to 7-stable? >=20 > The reason I ran into this is I am maintaining portupgrade, and working= > on ports/147242 and ports/131111. Both of which seem to be due to > script(1) returning the wrong exit status. >=20 > 7.x is EoL Feb 2013 [1]. Given that, and that script(1)'s return code > cannot be relied on for automated scripts. I am wondering what the > thoughts are on putting this patch out as an errata? >=20 > Regards, > Bryan Drewery >=20 > [1] http://www.freebsd.org/security/ >=20 It was reported to me that this is broken at least as far back as 4.7. I think the changes attributed in bin/146189 just made it come to light quicker. Still would be nice if this was MFC'd to 7-STABLE. Regards, Bryan Drewery --------------enig25950D3E0AFAE1F9752655F5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPxXUHAAoJEG54KsA8mwz5Y5kP/icZXFJi5synZtWyIlSd29j1 kJ03FTPhwTUzbB6H+7glLmvJMgfQZl2NNPmu29RJBYRqWt8Wcbv8VxLxH2emCRJf MBmZu95gF8JEk31sU0igB+Gp0SPLuoWMoUaesr0UrKqeazvlxGY52HlUvZs5JJLU C4jQE9ymLjAnN4wshAAaM4BlNcu8hHQZ8tQZGxJhiz/f1BmSBBVUiAS2NJMfU+SV SINN1mv5zL3TPzudRy4tX/cD3RdCwYxQvRtDRae4Rpd7yOfa3Ggyb+rvPbY7TaSw gTQ5Tc5P6ytixw+0olHH2aPqf7YUgO2FvwWJvEOnJPGAMfOfHs3EdmwTVgWA+Rj6 9q1XzWQYsBBEUr9UPOyiUoMoGhLXo4B68z8Y//mF/oQxh2zKi2amGtL973KR/gkh NU+LPfVsBRYHONEL+UKFosTOQxTiNXGuUGE6jY0uKAKdn+YX8TczT/tB5Xx2Dw1r 9aZdaWUmF/ReR3ePJQf/IKZE4HFcQW6fEVtFEt5a1fN4ThRxBhb2WaCwmph9an9D /UPiAUpwA8i3jqKyKNjT7nU+xEAOCfVQl8xgPQaspR6rzt4PBmSq66swVdDnGA+a wOapOPB3rfV9apIzyAAvZXrY/u455ERSkdVgt/shJoJKSFBDZljTPtl4PL4gZgq3 KL35QOOAczhR2Y145M00 =WdNF -----END PGP SIGNATURE----- --------------enig25950D3E0AFAE1F9752655F5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FC57507.8070008>