Date: Fri, 29 Oct 2010 20:29:25 +0200 From: Attilio Rao <attilio@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r214446 - in head/sys: amd64/amd64 conf i386/i386 x86/x86 Message-ID: <AANLkTim3zT9vPq6BKhqFsOD9vOdcbC4TJJar6cahWG=c@mail.gmail.com> In-Reply-To: <201010291339.18565.jkim@FreeBSD.org> References: <201010280758.o9S7w6Vj069186@svn.freebsd.org> <201010291339.18565.jkim@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
2010/10/29 Jung-uk Kim <jkim@freebsd.org>: > On Thursday 28 October 2010 03:58 am, Attilio Rao wrote: >> Author: attilio >> Date: Thu Oct 28 07:58:06 2010 >> New Revision: 214446 >> URL: http://svn.freebsd.org/changeset/base/214446 >> >> Log: >> Merge the mptable support from MD bits to x86 subtree. >> >> Sponsored by: Sandvine Incorporated >> Discussed with: jhb > > This commit broke amd64 build with "device mptable". I had to do the > following to fix sys/x86/x86/mptable.c: > > @@ -27,7 +27,9 @@ > #include <sys/cdefs.h> > __FBSDID("$FreeBSD$"); > > +#ifdef __i386__ > #include "opt_mptable_force_htt.h" > +#endif > #include <sys/param.h> > #include <sys/systm.h> > #include <sys/bus.h> > > Alternatively, you may add "MPTABLE_FORCE_HTT" in > sys/conf/options.amd64 but I am not sure this option is useful for > amd64. Gosh, I left it out. Yes, I think this should be the right fix. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einsteinhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTim3zT9vPq6BKhqFsOD9vOdcbC4TJJar6cahWG=c>