Date: Sat, 7 Dec 1996 17:58:30 +1100 From: Bruce Evans <bde@zeta.org.au> To: dg@root.com, peter@spinner.dialix.com Cc: bde@zeta.org.au, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, dyson@freebsd.org, dyson@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/include endian.h Message-ID: <199612070658.RAA18540@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>>Perhaps we should seriously consider using 'cc -include opt_global.h' and >>moving things like Ix86_CPU etc into there? It has the benefits of having >>every file know about the settings, but without having to modify every file. > > I'd rather see a #include added to cpufunc.h, which is included by systm.h, >which is included by everything (?) in the kernel. cpufunc.h shouldn't be included in systm.h. This has been on my list of things to fix since FreeBSD-1.1. It is fixed in NetBSD. Only the ffs() and fls() functions in our version are used in machine-independent code (except possibly in spls), and these functions probably shouldn't be written in asm anyway (on Pentiums the asm versions are about the same speed as naive C versions if everything is in the L1 cache). systm.h is included for 501 out of 521 objects in LINT in -current. It is actually used for only 442 of these objects. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612070658.RAA18540>