Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 05 Mar 2018 10:08:04 -0800
From:      John Baldwin <jhb@freebsd.org>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211
Message-ID:  <1861296.ksaTdANMae@ralph.baldwin.cx>
In-Reply-To: <201803050754.w257swAE001435@repo.freebsd.org>
References:  <201803050754.w257swAE001435@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote:
> Author: eadler
> Date: Mon Mar  5 07:54:57 2018
> New Revision: 330451
> URL: https://svnweb.freebsd.org/changeset/base/330451
> 
> Log:
>   MFC r306837:
>   
>   [net80211] extend the ieee80211_rx_stats struct to include more information.

Have you thought about the KBI implications of this change and some of the
other changes you've merged?  In theory we try to not break existing kernel
modules on a stable branch.  That is, one should be able to kldload an
if_iwn.ko built on 11.0 on a 11-stable kernel.  If this structure is used by
any device drivers directly then changing its layout would seem to break
existing modules that were built against the old ABI and pass in pointers to
the old structures to functions in the kernel.  There are some fuzzy areas in
the ABI we try to preserve, but we generally try to keep drivers working.

Also, we may choose to break the ABI if there is a strong argument for it,
but then that is usually something discussed with re@ and noted in the commit
log and UPDATING.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1861296.ksaTdANMae>