Date: Sat, 22 Feb 2014 15:24:38 +0100 From: =?utf-8?Q?Hans_Petter_Selasky?= <hans.petter.selasky@bitfrost.no> To: =?utf-8?Q?Rohit_Grover?= <rgrover1@gmail.com>, =?utf-8?B?6buE5paH6L6J?= <huanghwh@gmail.com> Cc: =?utf-8?Q?Cory_Smelosky?= <b4@gewt.ne>, =?utf-8?Q?Danilo_E=2E_Go?= =?utf-8?Q?ndolfo?= <danilo@freebsd.org>, =?utf-8?Q?Alfred_Perlstein?= <bright@mu.org>, =?utf-8?Q?freebsd-drivers=40freebsd=2Eorg?= <freebsd-drivers@freebsd.org> Subject: RE: Macbook touchpad driver Message-ID: <zarafa.5308b326.52d4.746fb7e41a4939c2@mail.lockless.no> In-Reply-To: <CAE2MNTh2eP0zDRMnP-vcpZtSM2A7s9s8twWdzKHzCXYM75OEnA@mail.gmail.com> References: <CAB8uncZt_eMofgaEs83%2BXmFroccnnVYo0RbYQCZYc8M4aO%2BQTQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
Hi Rohit, Your work is very interesting. I can facilitate the merging of the two drivers. Can you ensure that the following patches are included in the updated atp.c driver aswell? http://svnweb.freebsd.org/base?view=revision&revision=261827 Thank you! --HPS -----Original message----- From: Rohit Grover <rgrover1@gmail.com> Sent: Saturday 22nd February 2014 14:53 To: 黄文辉 <huanghwh@gmail.com> Cc: Lundberg, Johannes <johannes@brilliantservice.co.jp>; Alfred Perlstein <bright@mu.org>; Danilo E. Gondolfo <danilo@freebsd.org>; Cory Smelosky <b4@gewt.ne>; hselasky@freebsd.org; freebsd-drivers@freebsd.org Subject: Re: Macbook touchpad driver Hello, I have merged the recent work done by Huang Wen Hui to support Wellspring trackpads into the original 'atp' driver. 'atp' supports two distinct families of Apple trackpad products: the older Fountain/Geyser and the latest Wellspring trackpads. The first version made its appearance with FreeBSD8 and worked only with the Fountain/Geyser hardware. A fork of this driver for Wellspring was contributed by Huang Wen Hui. This new driver unifies the Wellspring effort and also improves upon the original work. I have been testing it on a recent MacBookPro (Wellspring trackpad) and I am satisfied with it. It includes all the features of the original driver and should be able to support both families of hardware. I would like to solicit help to test this driver widely; especially on older Fountain/Geyser hardware. I would also like to initiate the review process to commit this to FreeBSD. https://github.com/rgrover/freebsd-atp thanks, rohit. On Sat, Feb 8, 2014 at 11:20 AM, Rohit Grover <rgrover1@gmail.com <mailto:rgrover1@gmail.com> > wrote: Hi Huang, I've started my work on the merge of your wellspring port and atp. Progress of this work can be tracked at https://github.com/rgrover/freebsd-atp regards, rohit. On Sat, Feb 1, 2014 at 8:53 AM, Rohit Grover <rgrover1@gmail.com <mailto:rgrover1@gmail.com> > wrote: Hi, Thanks for bringing this to my attention. I'll try to merge the two. thanks a lot! rohit. On 02/01/2014 01:26 AM, Huang Wen Hui wrote: > Hi, > In head there is a working driver base on atp(4) and bcm5974.c for > modem Macbooks, It is better to merge to ATP(4). > I am not sure how is hard to do it. > > Cheers, > > Huang Wen Hui. > > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=70658+0+current/freebsd-current <http://docs.freebsd.org/cgi/getmsg.cgi?fetch=70658+0+current/freebsd-current>; From owner-freebsd-drivers@FreeBSD.ORG Sat Feb 22 14:26:20 2014 Return-Path: <owner-freebsd-drivers@FreeBSD.ORG> Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9FA19E3; Sat, 22 Feb 2014 14:26:20 +0000 (UTC) Received: from mta05.bitpro.no (mta05.bitpro.no [92.42.64.202]) by mx1.freebsd.org (Postfix) with ESMTP id 42A711BEF; Sat, 22 Feb 2014 14:26:19 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta05.bitpro.no (Postfix) with ESMTPS id EC7B017FC51; Sat, 22 Feb 2014 15:26:11 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id 604BF180F9C; Sat, 22 Feb 2014 15:27:09 +0100 (CET) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jXjSAS2qQwgI; Sat, 22 Feb 2014 15:27:08 +0100 (CET) Received: from mail.lockless.no (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id 45CCB180F8D; Sat, 22 Feb 2014 15:27:08 +0100 (CET) Subject: RE: Macbook touchpad driver From: =?utf-8?Q?Hans_Petter_Selasky?= <hans.petter.selasky@bitfrost.no> To: =?utf-8?Q?Rohit_Grover?= <rgrover1@gmail.com>, =?utf-8?B?6buE5paH6L6J?= <huanghwh@gmail.com> Date: Sat, 22 Feb 2014 15:27:08 +0100 Mime-Version: 1.0 In-Reply-To: <CAE2MNTh2eP0zDRMnP-vcpZtSM2A7s9s8twWdzKHzCXYM75OEnA@mail.gmail.com> References: <CAB8uncZt_eMofgaEs83+XmFroccnnVYo0RbYQCZYc8M4aO+QTQ@mail.gmail.com> X-Priority: 3 (Normal) X-Mailer: Zarafa 7.1.4-41394 Message-Id: <zarafa.5308b3bc.5325.15fb0f2333cf7a28@mail.lockless.no> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: =?utf-8?Q?Cory_Smelosky?= <b4@gewt.ne>, =?utf-8?Q?Danilo_E._Go?= =?utf-8?Q?ndolfo?= <danilo@freebsd.org>, =?utf-8?Q?Alfred_Perlstein?= <bright@mu.org>, =?utf-8?Q?freebsd-drivers@freebsd.org?= <freebsd-drivers@freebsd.org> X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Writing device drivers for FreeBSD <freebsd-drivers.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-drivers>, <mailto:freebsd-drivers-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-drivers/>; List-Post: <mailto:freebsd-drivers@freebsd.org> List-Help: <mailto:freebsd-drivers-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-drivers>, <mailto:freebsd-drivers-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sat, 22 Feb 2014 14:26:20 -0000 BTW: Can you also update the ATP manual page. Please fetch it from freebsd-current as of today. I made some changes there recently. --HPS -----Original message----- From: Rohit Grover <rgrover1@gmail.com> Sent: Saturday 22nd February 2014 14:53 To: 黄文辉 <huanghwh@gmail.com> Cc: Lundberg, Johannes <johannes@brilliantservice.co.jp>; Alfred Perlstein <bright@mu.org>; Danilo E. Gondolfo <danilo@freebsd.org>; Cory Smelosky <b4@gewt.ne>; hselasky@freebsd.org; freebsd-drivers@freebsd.org Subject: Re: Macbook touchpad driver Hello, I have merged the recent work done by Huang Wen Hui to support Wellspring trackpads into the original 'atp' driver. 'atp' supports two distinct families of Apple trackpad products: the older Fountain/Geyser and the latest Wellspring trackpads. The first version made its appearance with FreeBSD8 and worked only with the Fountain/Geyser hardware. A fork of this driver for Wellspring was contributed by Huang Wen Hui. This new driver unifies the Wellspring effort and also improves upon the original work. I have been testing it on a recent MacBookPro (Wellspring trackpad) and I am satisfied with it. It includes all the features of the original driver and should be able to support both families of hardware. I would like to solicit help to test this driver widely; especially on older Fountain/Geyser hardware. I would also like to initiate the review process to commit this to FreeBSD. https://github.com/rgrover/freebsd-atp thanks, rohit. On Sat, Feb 8, 2014 at 11:20 AM, Rohit Grover <rgrover1@gmail.com <mailto:rgrover1@gmail.com> > wrote: Hi Huang, I've started my work on the merge of your wellspring port and atp. Progress of this work can be tracked at https://github.com/rgrover/freebsd-atp regards, rohit. On Sat, Feb 1, 2014 at 8:53 AM, Rohit Grover <rgrover1@gmail.com <mailto:rgrover1@gmail.com> > wrote: Hi, Thanks for bringing this to my attention. I'll try to merge the two. thanks a lot! rohit. On 02/01/2014 01:26 AM, Huang Wen Hui wrote: > Hi, > In head there is a working driver base on atp(4) and bcm5974.c for > modem Macbooks, It is better to merge to ATP(4). > I am not sure how is hard to do it. > > Cheers, > > Huang Wen Hui. > > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=70658+0+current/freebsd-current <http://docs.freebsd.org/cgi/getmsg.cgi?fetch=70658+0+current/freebsd-current>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?zarafa.5308b326.52d4.746fb7e41a4939c2>