Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Mar 2010 23:30:04 -0800
From:      Garrett Cooper <yanefbsd@gmail.com>
To:        d@delphij.net
Cc:        freebsd-stable@freebsd.org
Subject:   Re: I broke my SSH to jails after 7.2-8.0 src upgrade
Message-ID:  <7d6fde3d1003112330s15b0d1edjdcd885d29c4680d0@mail.gmail.com>
In-Reply-To: <4B99C5FA.4020801@delphij.net>
References:  <4B99AAD3.9060606@ibctech.ca> <a78074951003111849m7f9aa56fkd4ec9bbafcd395ee@mail.gmail.com> <4B99B197.3060504@ibctech.ca> <4B99B2E2.6050705@ibctech.ca> <4B99BB0E.7080000@delphij.net> <4B99C270.9040703@ibctech.ca> <7d6fde3d1003112033k3ce3b040y8edac8772747862f@mail.gmail.com> <4B99C5FA.4020801@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 11, 2010 at 8:41 PM, Xin LI <delphij@delphij.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 2010/03/11 20:33, Garrett Cooper wrote:
>> I've done a few RELENG_8_0 to STABLE-8 to 9-CURRENT upgrades lately
>> and mergemaster was goofing up the contents a bit based on the RCS
>> versions. I had to hand-edit a crapload of stuff going from 8 to 9,
>> and I still don't trust mergemaster's automatic merging logic because
>> it goofs up on /etc/group // /etc/passwd still (doesn't merge
>> anything, discards my info, etc) for starters.
>>
>> -a doesn't actually do any merging though, FWIW:
>>
>> =A0 =A0 =A0-a =A0 =A0 =A0 =A0 =A0Run automatically. =A0This option will =
leave all the files that
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0differ from the installed versions in=
 the temporary directory
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0to be dealt with by hand. =A0If the t=
emproot directory exists,
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0it creates a new one in a previously =
non-existent directory.
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0This option unsets the verbose flag, =
but other than -U it is
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0compatible with all other options. =
=A0Setting -a makes -w
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0superfluous.
>>
>> Also, "add path pts unhide" unmasks all psuedo TTY dev nodes so that
>> applications that use openpty(3) and friends (like sshd) can allocate
>> them at login.
>
> Yes that's right. =A0Thanks for posting, perhaps we can document it in FA=
Q?

Unfortunately this doesn't really fit in a FAQ because it could be any
of the failures caused by openpty failure:

ERRORS
     The openpty() function may fail and set the global variable errno for =
any
     of the errors specified for the grantpt(3), posix_openpt(3), ptsname(3=
),
     and unlockpt(3) functions and the revoke(2) system call.

     In addition to this, forkpty() may set it to any value as described fo=
r
     fork(2).

Note how openpty(3) isn't descriptive in terms of _what_ individual
failures can be reported by it, but instead point to other manpages
:)... I've run into whacky ass issues with /var/run permissions in the
past, etc, which is why I don't suggest putting this into a FAQ -- the
bucket is way too huge to deal with.

Steve's right though -- if you're willing to use an option and the
documentation clearly states the exact behavior and caveats, you are
responsible for the results of any failure through misuse of the tool
(exceptions being IMO NUL pointer exceptions, abort(3) calls not
thrown by assert(3)s, etc). You're more than welcome to make
suggestions on how things can be improved, but as I've discovered in
some areas, some of the suggestions one makes aren't necessarily
accepted with open minds.

Excessive and/or redundant documentation (as I'm starting to
understand after playing the opposite side for a while) is no better
than little or no documentation; complete and concise documentation is
what's needed more than anything else.

Thanks,
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d1003112330s15b0d1edjdcd885d29c4680d0>