Date: Thu, 30 Mar 2017 09:36:31 +0100 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= <royger@FreeBSD.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r316140 - stable/10/sys/dev/xen/netfront Message-ID: <20170330083631.dtututkocx3t24pb@dhcp-3-128.uk.xensource.com> In-Reply-To: <4E2E5DD5-58CB-4847-8E7A-CCF6734E8904@gmail.com> References: <201703291534.v2TFYq2j041847@repo.freebsd.org> <4E2E5DD5-58CB-4847-8E7A-CCF6734E8904@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 29, 2017 at 10:12:23AM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On Mar 29, 2017, at 08:34, Roger Pau Monné <royger@FreeBSD.org> wrote: > > > > Author: royger > > Date: Wed Mar 29 15:34:52 2017 > > New Revision: 316140 > > URL: https://svnweb.freebsd.org/changeset/base/316140 > > > > Log: > > xen/netfront: release resources on removal > > > > Current netfront code doesn't release the resources (grants and mbufs) on > > removal. Add a new helper that releases the resources, so FreeBSD doesn't run > > out of grants or memory when performing heavy hotplug/unplug of Xen PV nic > > devices. > > > > This is a direct commit to stable/10 because the code in newer branches has > > been completely refactored and no longer has this issue. > > > > Reviewed by: royger > > Submitted by: Ouyangzhaowei <ouyangzhaowei@huawei.com> > > Differential review: https://reviews.freebsd.org/D10088 > > Hi Roger, > This broke GENERIC/i386 with a -Wformat warning, but was fixed in r316170. Sight. It was supposedly "thoroughly tested". Sorry for the breakage and thanks for the fix! Roger.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170330083631.dtututkocx3t24pb>