Date: Tue, 3 Jun 2014 07:24:04 +0800 From: =?GB2312?Q?"=BB=C6=CE=C4=BB=D4=40Gmail"?= <huanghwh@gmail.com> To: Ed Maste <emaste@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [patch] Switch to text mode during efi boot Message-ID: <844FB0BB-1AE5-4CFC-8EC9-634E7B0E6125@gmail.com> In-Reply-To: <CAPyFy2C0TOenDmvLa1%2Bp%2BaFKkv5=4coQ=K_5Wfb1LRAFXd1fsw@mail.gmail.com> References: <CAG3jReLhdO7xdM8W8M65iokD9y5tFDTR7vRO0Tz8C6d0e5Q3Jw@mail.gmail.com> <CAPyFy2C0TOenDmvLa1%2Bp%2BaFKkv5=4coQ=K_5Wfb1LRAFXd1fsw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ed, Is there any progress about framebuffer corruption? Thanks, Huang Wenhui > =D4=DA 2014=C4=EA5=D4=C222=C8=D5=A3=AC23:54=A3=ACEd Maste <emaste@freebsd.= org> =D0=B4=B5=C0=A3=BA >=20 >> On 22 May 2014 11:32, Rafael Esp=A8=AAndola <rafael.espindola@gmail.com> w= rote: >> The attached patch causes both boot1 and loader.efi to switch to text >> mode. This only >> seems to make a difference on Macs where otherwise no information was bei= ng >> displayed. >>=20 >> The ConsoleControl.h file is copied from >> EdkCompatibilityPkg/Foundation/Protocol/ConsoleControl in >> https://github.com/tianocore/edk2. >>=20 >> I tested that both programs are able to change to text mode by >> enabling only one of them at a time. >>=20 >> With this patch I am able to see loaders output on all the macs I >> tried. The kernel boots correctly on a MacPro, but unfortunately it >> doesn't seem to be able to find the efi buffer in a MacBookPro. >=20 > Great, thank you Rafael. There's framebuffer corruption issues on > some other hardware as well, so it may be that the eventual fix for > those will also solve the MBP issue. >=20 >> Some design questions: >>=20 >> * Why do we have both boot1 and loader? It is just the issue with >> building a usb image without root that requires having a boot1 that >> has a predictable size? >=20 > No, boot1.efi only exists so that the loader and related Forth and > config files can be placed in a UFS root filesystem, as is done with > the x86 BIOS boot and on other platforms. This way the UEFI boot > easily integrates with the existing installer and tools. >=20 > We could put the loader and files in the FAT EFI system partition > instead, but it would require more substantial changes in the > installer and system configuration. >=20 >> * Even if we want to keep both boot1 and loader, could boot1 use libefi? >=20 > I don't think there's any fundamental reason we couldn't. However, > we're going to need to take a broader look at reworking some of this > in the context of secure boot anyway (as we look at a signed shim > loader). >=20 >> * Is it ok to always switch to text mode in libefi or should it >> provide a switch_to_text_mode function? >=20 > I suspect it's fine / correct to always switch; we've just been > "lucky" that the current approach works with most firmwares. > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?844FB0BB-1AE5-4CFC-8EC9-634E7B0E6125>