Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Jan 2010 19:39:33 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r203232 - projects/capabilities8/sys/fs/fdescfs
Message-ID:  <201001301939.o0UJdX89088424@svn.freebsd.org>

index | next in thread | raw e-mail

Author: rwatson
Date: Sat Jan 30 19:39:33 2010
New Revision: 203232
URL: http://svn.freebsd.org/changeset/base/203232

Log:
  Merge c173596 from the p4 TrustedBSD Capabilities branch to capabilities8:
  
    Don't allow VOP_SETATTR() on fdescfs -- we could build up a capability
    rights mask for the operations it represents, but it actually isn't very
    coherent conceptually.  For example, you can chmod /dev/fd/X if that fd
    refers to a file, but if you stat() you don't see the file's mode.
  
  Sponsored by:	Google, Inc.

Modified:
  projects/capabilities8/sys/fs/fdescfs/fdesc_vnops.c

Modified: projects/capabilities8/sys/fs/fdescfs/fdesc_vnops.c
==============================================================================
--- projects/capabilities8/sys/fs/fdescfs/fdesc_vnops.c	Sat Jan 30 19:36:55 2010	(r203231)
+++ projects/capabilities8/sys/fs/fdescfs/fdesc_vnops.c	Sat Jan 30 19:39:33 2010	(r203232)
@@ -391,6 +391,8 @@ fdesc_getattr(ap)
 		struct ucred *a_cred;
 	} */ *ap;
 {
+
+#if 0
 	struct vnode *vp = ap->a_vp;
 	struct vattr *vap = ap->a_vap;
 
@@ -430,6 +432,9 @@ fdesc_getattr(ap)
 
 	vp->v_type = vap->va_type;
 	return (0);
+#else
+	return (EOPNOTSUPP);
+#endif
 }
 
 static int


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001301939.o0UJdX89088424>