Date: Sat, 7 Nov 2009 15:30:03 GMT From: Jilles Tjoelker <jilles@stack.nl> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/40282: [patch] kill(1) has bad error checking for command line parameters Message-ID: <200911071530.nA7FU3rm049422@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/40282; it has been noted by GNATS. From: Jilles Tjoelker <jilles@stack.nl> To: bug-followup@FreeBSD.org, oleg@reis.zp.ua Cc: Subject: Re: bin/40282: [patch] kill(1) has bad error checking for command line parameters Date: Sat, 7 Nov 2009 16:21:46 +0100 I think the idea of aborting on syntax errors makes sense, but aborting on a kill(2) error seems to go too far. I have found various shells (tcsh, real ksh) that stop processing a kill builtin if they encounter an invalid pid (if there were any previous valid pids, signals will have been sent), but have not found any that stop processing if a kill(2) returns an error. By the way, do not imply anything about command behaviour from /usr/bin/which. sh(1) and bash(1) do not have a which(1) builtin, so /usr/bin/which will be used, which does not know about shell builtins. It just happens to be the case that sh(1) does not have a kill builtin (although that may change in the future) and bash's kill builtin handles errors the same way as our /bin/kill. You can use 'type' for accurate information in these shells. -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911071530.nA7FU3rm049422>