Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Sep 2021 01:41:49 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: f4d49d0a6cd0 - stable/12 - e1000: clean LTO warnings
Message-ID:  <202109240141.18O1fnX4039684@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=f4d49d0a6cd01a2004dc83fce695270615c6fe74

commit f4d49d0a6cd01a2004dc83fce695270615c6fe74
Author:     Andrzej Ostruszka <aostruszka@marvell.com>
AuthorDate: 2019-11-07 15:03:15 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-09-24 01:40:13 +0000

    e1000: clean LTO warnings
    
    During LTO build compiler reports some 'false positive' warnings about
    variables being possibly used uninitialized.  This patch silences these
    warnings.
    
    Exemplary compiler warning to suppress (with LTO enabled):
    error: 'link' may be used uninitialized in this function
    [-Werror=maybe-uninitialized]
      if (link) {
    
    Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
    
    Approved by:    imp
    Obtained from:  DPDK (46136031f19107f4e9b6b3a952cb7f57877a7f0f)
    MFC after:      1 week
    
    (cherry picked from commit 089cdb3990f47be3cd34d1a57567a2e89c917929)
---
 sys/dev/e1000/e1000_82543.c   | 2 +-
 sys/dev/e1000/e1000_ich8lan.c | 2 +-
 sys/dev/e1000/e1000_phy.c     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/dev/e1000/e1000_82543.c b/sys/dev/e1000/e1000_82543.c
index ac81cbd296f2..b9c6e439480a 100644
--- a/sys/dev/e1000/e1000_82543.c
+++ b/sys/dev/e1000/e1000_82543.c
@@ -1062,7 +1062,7 @@ static s32 e1000_setup_copper_link_82543(struct e1000_hw *hw)
 {
 	u32 ctrl;
 	s32 ret_val;
-	bool link;
+	bool link = true;
 
 	DEBUGFUNC("e1000_setup_copper_link_82543");
 
diff --git a/sys/dev/e1000/e1000_ich8lan.c b/sys/dev/e1000/e1000_ich8lan.c
index 0311fdb3fef6..b29d53ea4b54 100644
--- a/sys/dev/e1000/e1000_ich8lan.c
+++ b/sys/dev/e1000/e1000_ich8lan.c
@@ -5620,7 +5620,7 @@ void e1000_igp3_phy_powerdown_workaround_ich8lan(struct e1000_hw *hw)
 void e1000_gig_downshift_workaround_ich8lan(struct e1000_hw *hw)
 {
 	s32 ret_val;
-	u16 reg_data;
+	u16 reg_data = 0;
 
 	DEBUGFUNC("e1000_gig_downshift_workaround_ich8lan");
 
diff --git a/sys/dev/e1000/e1000_phy.c b/sys/dev/e1000/e1000_phy.c
index d84b6120dd31..2eae3acbe500 100644
--- a/sys/dev/e1000/e1000_phy.c
+++ b/sys/dev/e1000/e1000_phy.c
@@ -1695,7 +1695,7 @@ s32 e1000_copper_link_autoneg(struct e1000_hw *hw)
 s32 e1000_setup_copper_link_generic(struct e1000_hw *hw)
 {
 	s32 ret_val;
-	bool link;
+	bool link = true;
 
 	DEBUGFUNC("e1000_setup_copper_link_generic");
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109240141.18O1fnX4039684>