Date: Fri, 23 Feb 2001 08:55:26 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Doug Rabson <dfr@nlsystems.com> Subject: Re: cvs commit: src/sys/alpha/alpha swtch.s Message-ID: <XFMail.010223085526.jhb@FreeBSD.org> In-Reply-To: <Pine.BSF.4.21.0102231727190.8957-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23-Feb-01 Bruce Evans wrote: > On Thu, 22 Feb 2001, John Baldwin wrote: > >> I've thought about doing that, yes. If you want, I can stick it on my todo >> list. Also, I have managed to make userret() and ast() (modulo a few >> commits >> coming up in the next 15 minutes or so) the same across all architectures. >> Do you think that given that it would be feasible to move those two >> functions >> to sys/kern/subr_trap.c and let them be MI? > > I'm not sure that ast() should be MI. It was in hardware on vaxes. There's an IPL level on teh alphas for software interrupts that we don't use at the moment as well. >> Also, as a sidenote, I think that addupc_task() should take a uniptr_t, not >> a >> uint64_t as its second argument.. > > Nah, uniptr_t (sic) only exists on vaxes where all types are the same :-). > > I think it should take a register_t or uintfptr_t. uintptr_t is only > required to work for object pointers. Instruction pointer values in > trap frames aren't even C pointers. They normally (should) have type > register_t. However, the parts of the profiling code that I cleaned > up used uintfptr_t or intfptr_t for representing instruction pointer > values. Hmm, I take it the 'f' isn't some weird variant of 'instruction', so there is no generic 'instruction address' type that we can use, so we (ab)use uintfptr_t instead? (Not that uintptr_t isn't a similar abuse for data pointers. :) > Bruce -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010223085526.jhb>