Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Mar 2022 19:51:27 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 262515] Missing filecaps_free() in many places
Message-ID:  <bug-262515-227-96ER29pzgT@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-262515-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-262515-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262515

--- Comment #4 from Mateusz Guzik <mjg@FreeBSD.org> ---
I agree it should be on demand, but I have further notes.

1. fd-related code in namei_setup needs to be factored away to kern_descrip=
.c.

2. if the caller does not care to look at caps, we can make a copy without
allocating anything (and subsequently without having to free anything). as
shown in the reproducer, the only part which requires malloc is ioctl handl=
ing,
but ioctls are not inspected in the lookup itself.

3. instead of direct filecaps_free perhaps NDFREE_CAPS or similar should be
provided

I'll sleep on it and probably hack it up over the weekend. It will be mfcab=
le.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-262515-227-96ER29pzgT>