Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Feb 2026 00:46:50 +0000
From:      Bjoern A. Zeeb <bz@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 717240c95d29 - main - ath10k: add sysctl to turn on/off fwlog
Message-ID:  <698a7ffa.308f7.50b58e7a@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=717240c95d297711d3bed0bb8b4cc8403ecbfd6a

commit 717240c95d297711d3bed0bb8b4cc8403ecbfd6a
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2025-12-08 18:47:45 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2026-02-09 21:49:45 +0000

    ath10k: add sysctl to turn on/off fwlog
    
    FWLOG, if compiled in, was on by default without a way to stop it from
    printing everything to the console.  Add a modparam to enable it with
    it being disabled by default if available.
    
    MFC after:      3 days
---
 sys/contrib/dev/athk/ath10k/fwlog.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/sys/contrib/dev/athk/ath10k/fwlog.c b/sys/contrib/dev/athk/ath10k/fwlog.c
index fb1e292fe2e4..9ea4d36c2c7c 100644
--- a/sys/contrib/dev/athk/ath10k/fwlog.c
+++ b/sys/contrib/dev/athk/ath10k/fwlog.c
@@ -14,10 +14,20 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
+#if defined(__FreeBSD__)
+#define	LINUXKPI_PARAM_PREFIX	ath10k_fwlog_
+#endif
+
 #include "core.h"
 #include "debug.h"
 #if defined(__FreeBSD__)
 #include "fwlog.h"
+
+#include <linux/module.h>	/* modparam */
+
+static bool enable;
+module_param(enable, bool, 0644);
+MODULE_PARM_DESC(enable, "Enable firmware loggging.");
 #endif
 
 #define FW_DBGLOG_TIMESTAMP_OFFSET	0
@@ -1526,6 +1536,13 @@ static void ath10k_fwlog_print_work(struct work_struct *work) {
 
 void ath10k_handle_fwlog_msg(struct ath10k *ar, struct sk_buff *skb) {
 
+#if defined(__FreeBSD__)
+	if (!enable) {
+		dev_kfree_skb(skb);
+		return;
+	}
+#endif
+
 	if (!test_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags)) {
 		ath10k_warn(ar, "ignoring fwlog event!!!\n");
 		dev_kfree_skb(skb);


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?698a7ffa.308f7.50b58e7a>