Date: Wed, 6 Dec 2017 16:48:53 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... Message-ID: <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> In-Reply-To: <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org> References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <ea6c8eb5-f849-df2a-ab80-75d8ebc1edb8@FreeBSD.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WEE857xEE8GMxMD9Ed18XLuxhN45DwR4N Content-Type: multipart/mixed; boundary="OVuWltfChgeUHVBH8Ld2XefD1sbpM0V9v"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <ea6c8eb5-f849-df2a-ab80-75d8ebc1edb8@FreeBSD.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org> In-Reply-To: <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org> --OVuWltfChgeUHVBH8Ld2XefD1sbpM0V9v Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/6/2017 4:38 PM, Bryan Drewery wrote: > On 12/6/2017 4:28 PM, Hans Petter Selasky wrote: >> On 12/07/17 01:10, Bryan Drewery wrote: >>> I'm a bit speechless.=C2=A0 Why??=C2=A0 The old version was 90% fine = and I sent >>> you advice on how to make it work with the new layout. >> >> Hi, >> >> I tried to listen to your advice, splitting up the Makefiles, not >> listing every dependency. Further how the OFED libraries are linked ha= s >> changed. Two iterations for building the OFED libraries is not enough,= >> like before. We really need four iterations. >> >> I don't see how the current approach is "wrong". Can you explain a bit= >> more? >=20 > 1. SUBDIR=3D../../somewhere else is inherently wrong. > 2. Building a library from a directory named '2' is wrong. > 3. Not just using proper SUBDIR_DEPEND and making all these subdirs is > not needed and complicates things MORE by splitting them all up. > 4. Building a library from a directory where its real bsd.lib.mk is not= > at is wrong. > 5. Depending on an include directory in the Makefile.inc1 library > dependencies is simply not needed - I told you that. > 6. Using these /0 /1 /2 /3 directories actually hurts the 'make > libraries' parallelism/dependency graph. It ends up building /1 rather > than building libibcm and libibumad directly in its graph. It creates > an indirection which adds more unneeded submake recursion. >=20 > The whole thing needlessly obfuscates these libraries. >=20 > It's fine, I'm going to rewrite it all now. >=20 7. We don't put FreeBSD Makefiles in the same directory as contributed files. It's against the pattern. So moving contrib/ofed/usr.lib/* to contrib/ofed/*/ is wrong. It complicates future merges of contrib code. Really none of these Makefiles should be in contrib/ofed - the proper thing would be to move them out, not to inline them with the contributed code. --=20 Regards, Bryan Drewery --OVuWltfChgeUHVBH8Ld2XefD1sbpM0V9v-- --WEE857xEE8GMxMD9Ed18XLuxhN45DwR4N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaKI/1AAoJEDXXcbtuRpfPRxoIALYfm2/SBPlAVp778WD//Jef XDpBI8Eqh+kcbIErHmt2QAL1xbQUOsOg7zoGQ78Xfx6SKnu8fxkRgC4LlxE4nlRv sBWp6rXmIywrJRFR5Pduv/GdxRrRieq1UM0kN6vqmJu9e7dbsOnjMJfNnT2sTT3H XCC7MYy5W+bNeRVfjWdAQDSsIv6K5dNF8D0sHCxnE72xs1F6l9Bev2E27QmD6T30 JLUBIDa/fNEAHTYEkxbRx6BSlMgux3ngRmqzwFYuz1dHtZ1BMVKy61xs/7s1Nc66 y/hKwUFdy73f5RRNhtaEoqtYzALAqAETB4Bqvmqucq/r3wzXvHYD8IHnR9dClmo= =bdAu -----END PGP SIGNATURE----- --WEE857xEE8GMxMD9Ed18XLuxhN45DwR4N--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8e2fd368-ad3e-27bb-0834-4b6f2f99e905>