Date: Wed, 12 Dec 2007 11:37:12 +0900 From: "Hidetoshi Shimokawa" <simokawa@FreeBSD.ORG> To: "Sean Bruno" <sbruno@miralink.com> Cc: freebsd-scsi@freebsd.org, freebsd-firewire@freebsd.org, nate@root.org Subject: Re: scsi_target witness lock error Message-ID: <626eb4530712111837y4608e919w845461d36a18118f@mail.gmail.com> In-Reply-To: <1197425759.14437.0.camel@home-desk> References: <1197420795.2738.6.camel@iago.office.miralink.com> <86sl28snpe.wl%simokawa@FreeBSD.ORG> <1197425759.14437.0.camel@home-desk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/12/07, Sean Bruno <sbruno@miralink.com> wrote: > > --- //depot/vendor/freebsd/src/sys/cam/scsi/scsi_target.c 2007/04/15 08:53:22 > > +++ //depot/user/simokawa/firewire_lock/sys/cam/scsi/scsi_target.c 2007/05/21 14:31:55 > > @@ -372,10 +372,14 @@ > > int retval; > > > > softc = (struct targ_softc *)kn->kn_hook; > > +#if 0 > > cam_periph_lock(softc->periph); > > +#endif > > retval = !TAILQ_EMPTY(&softc->user_ccb_queue) || > > !TAILQ_EMPTY(&softc->abort_queue); > > +#if 0 > > cam_periph_unlock(softc->periph); > > +#endif > > return (retval); > > } > Are these two "if 0"'s supposed to be commented out? I'm leaving this > out of my RELENG_6 test for now unless you say otherwise. > > > Sean Yes, it is same as comment out. The patch was for RELENG_7 or current. I'm not sure about RELENG_6. -- /\ Hidetoshi Shimokawa \/ simokawa@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?626eb4530712111837y4608e919w845461d36a18118f>