Date: Wed, 20 Jun 2012 06:10:11 GMT From: Mark Linimon <linimon@lonesome.com> To: freebsd-rc@FreeBSD.org Subject: Re: conf/158127: [patch] remount_optional option in rc.initdiskless doesn't actually work Message-ID: <201206200610.q5K6ABG3018024@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/158127; it has been noted by GNATS.
From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: conf/158127: [patch] remount_optional option in
rc.initdiskless doesn't actually work
Date: Wed, 20 Jun 2012 01:01:04 -0500
----- Forwarded message from Dewayne <dewayne.geraghty@heuristicsystems.com.au> -----
Date: Wed, 20 Jun 2012 06:19:55 +1000
From: Dewayne <dewayne.geraghty@heuristicsystems.com.au>
To: stable@freebsd.org
Cc: brian@maven-group.org
Subject: Diskless ignore remount - fix (Re: conf/158127: [patch]
remount_optional option in rc.initdiskless doesn'
t actually work)
I notice that PR 158127 remains outstanding, June, 2011. I've enclosed a
patch for Stable 9.0, to correct diskless booting. When a mountpoint
fails, the failure may be ignored as required/documented.
--- /tmp/rc.initdiskless 2012-06-19 19:01:33.000000000 +1000
+++ /etc/rc.initdiskless 2012-06-19 19:02:16.000000000 +1000
@@ -166,7 +166,7 @@
chkerr() {
lastitem () ( n=$(($# - 1)) ; shift $n ; echo $1 )
mountpoint="$(lastitem $2)"
- [ -r $mountpoint/remount_optional ] && ( echo "$2 failed: ignoring due
to remount_optional" ; return )
+ [ -r $mountpoint/remount_optional ] && echo "$2 failed: ignoring due
to remount_optional" && return
case $1 in
0)
The patch has been tested with/without /conf/default/etc/remount_optional &
is functionally correct.
It would be appreciated if someone would verify and commit.
Regards, Dewayne.
PS My apologies if Outlook has corrupted the patches appearance,we have to
work with what we've got.
----- End forwarded message -----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206200610.q5K6ABG3018024>