Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Feb 2010 18:43:38 +0200
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Ruslan Ermilov <ru@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r203800 - in head/tools: regression/file/newfileops_on_fork regression/gaithrstress tools/mctest tools/netrate/http tools/netrate/httpd tools/netrate/juggle
Message-ID:  <20100212164338.GH9991@deviant.kiev.zoral.com.ua>
In-Reply-To: <201002121633.o1CGX3hd067423@svn.freebsd.org>
References:  <201002121633.o1CGX3hd067423@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--u0lqphHC8S+ob1K0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 12, 2010 at 04:33:03PM +0000, Ruslan Ermilov wrote:
> Author: ru
> Date: Fri Feb 12 16:33:03 2010
> New Revision: 203800
> URL: http://svn.freebsd.org/changeset/base/203800
>=20
> Log:
>   Fixed error checking of pthread(3) functions.
>  =20
>   PR:		143807
>   Submitted by:	pluknet (partly)
>=20
> Modified:
>   head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c
>   head/tools/regression/gaithrstress/gaithrstress.c
>   head/tools/tools/mctest/mctest.cc
>   head/tools/tools/netrate/http/http.c
>   head/tools/tools/netrate/httpd/httpd.c
>   head/tools/tools/netrate/juggle/juggle.c
>=20
> Modified: head/tools/regression/file/newfileops_on_fork/newfileops_on_for=
k.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c	Fr=
i Feb 12 15:07:24 2010	(r203799)
> +++ head/tools/regression/file/newfileops_on_fork/newfileops_on_fork.c	Fr=
i Feb 12 16:33:03 2010	(r203800)
> @@ -113,7 +113,7 @@ main(__unused int argc, __unused char *a
>  		err(-1, "bind");
>  	if (listen(listen_fd, -1) <0)
>  		err(-1, "listen");
> -	if (pthread_create(&accept_thread, NULL, do_accept, NULL) < 0)
> +	if (pthread_create(&accept_thread, NULL, do_accept, NULL) !=3D 0)
>  		err(-1, "pthread_create");
>  	sleep(1);	/* Easier than using a CV. */;
>  	do_fork();

err() uses errno, so this is still not quite right ?

--u0lqphHC8S+ob1K0
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iEYEARECAAYFAkt1hTkACgkQC3+MBN1Mb4g0/gCg0DkzuOyPjgTOnN202g1YinVl
8dYAoPH0SeCcshpbz6//kIiVgZ/g048R
=5vT8
-----END PGP SIGNATURE-----

--u0lqphHC8S+ob1K0--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100212164338.GH9991>