Date: Fri, 6 Nov 2015 17:00:52 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290417 - head Message-ID: <563D4D44.10109@FreeBSD.org> In-Reply-To: <563D4C4E.2050209@FreeBSD.org> References: <201511052148.tA5LmCNg042187@repo.freebsd.org> <563D4C4E.2050209@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 11/6/2015 4:56 PM, Bryan Drewery wrote:
> On 11/5/2015 1:48 PM, Warner Losh wrote:
>> -.include "share/mk/src.opts.mk"
>> -.include <bsd.arch.inc.mk>
>> -.include <bsd.compiler.mk>
>
> Fun fact, src.opts.mk is already including bsd.compiler.mk so it being
> here is redundant (since r263953 removed direct checks in
> COMPILER_TYPE/VERSION).
>
>> +# Cross toolchain changes must be in effect before bsd.compiler.mk
>> +# so that gets the right CC, and pass CROSS_TOOLCHAIN to submakes.
>> +.if defined(CROSS_TOOLCHAIN)
>> +LOCALBASE?= /usr/local
>> +.include "${LOCALBASE}/share/toolchains/${CROSS_TOOLCHAIN}.mk"
>> +CROSSENV+=CROSS_TOOLCHAIN="${CROSS_TOOLCHAIN}"
>> +.endif
>> +.include <bsd.compiler.mk> # don't depend on src.opts.mk doing it
That explains this comment. It was obscure to me.
>> +.include "share/mk/src.opts.mk"
>
>
--
Regards,
Bryan Drewery
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJWPU1EAAoJEDXXcbtuRpfPfX0H/R/PrNpDUkr86UMRhxCHWFK0
1MJQeEZ3DVDDITUfNEQas32uqFqvuzZCfh5d1WotaQXoGHxW1d6Oan8Ez5gtY+03
SMfDHTtBqGR5mF4jHxPApmu6YY4OGL4WuRGrymOZlYN3PDIA8VjZYFg3QfKm2Z07
R44cASlH6/J9vsMggWCMeNfqOQPq0i+uXwg4M1QbW81jDGdKZ5jK2j8w2DfKuZdT
tj3tLXatPJd66fYH2DljZDV08e1CRYEhMczrrVcOaxwDsON20cNGegCIBb1o7PFN
yJtLfkJif2IyF15nB9+KL09NIKqUGT8hjCN76hBu+IszC8rW4tZN/fiZu1qwA1A=
=U8nt
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?563D4D44.10109>