Date: Mon, 23 Apr 2018 08:44:15 -0700 From: Yuri <yuri@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468086 - in head/math: . piranha Message-ID: <b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b@freebsd.org> In-Reply-To: <20180423123756.fvitgl3rll4yikeq@ogg.in.absolight.net> References: <201804230903.w3N93LhK062379@repo.freebsd.org> <20180423123756.fvitgl3rll4yikeq@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/23/18 05:37, Mathieu Arnold wrote:
> Unless this really needs cmake and ninja to run, please reverse the way
> you create the BUILD_DEPENDS and RUN_DEPENDS variables. You may have
> noticed many ports do BUILD_DEPENDS=${RUN_DEPENDS} and RUN_DEPENDS=blah.
The way how they defined the build, it does involve cmake. cmake isn't
"really needed" because cmake doesn't really build anything, but it does
install it. It is also needed for the 'test' target.
You prefer it the way around, "BUILD_DEPENDS=${RUN_DEPENDS} and
RUN_DEPENDS=blah"? But doesn't it end up being the same?
Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b8c76e65-a4f4-9db2-ba9d-f2c9a43c417b>